cmake: Supports specifying link script prefix parameters #16710
+10
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiaoxiang781216
previously approved these changes
Jul 11, 2025
xuxin930
reviewed
Jul 14, 2025
For example, armclang does not support -T Signed-off-by: wangmingrong1 <wangmingrong1@xiaomi.com>
xiaoxiang781216
approved these changes
Jul 17, 2025
simbit18
reviewed
Jul 18, 2025
| @@ -659,8 +664,7 @@ if(NOT CONFIG_ARCH_SIM) | |||
| target_link_libraries( | |||
| nuttx | |||
| PRIVATE ${NUTTX_EXTRA_FLAGS} | |||
| -T | |||
| ${ldscript} | |||
| ${LINK_SCRIPT_FLAG}${ldscript} | |||
There was a problem hiding this comment.
add a space -> ${LINK_SCRIPT_FLAG} ${ldscript}
There was a problem hiding this comment.
It cannot add spaces here because the armclang linker script option --scatter= cannot have spaces
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Please adhere to Contributing Guidelines.
Summary
cmake: Supports specifying link script prefix parameters
For example, armclang does not support -T
Impact
No impact
Testing
ci