we think it'd be best to restore Symfony formats to the value it was initially when the request is done (for example in the ResponseProcessor ?). Doing this may allow some unwanted formats in the next request. ping @dunglas

we think it'd be best to restore Symfony formats to the value it was initially when the request is done (for example in the ResponseProcessor ?). Doing this may allow some unwanted formats in the next request. ping @dunglas

Yeah I don't know the internals of API Platform well enough to say this fix won't have side-effects on how the system reads MIME types elsewhere, so I can understand the concern. To fix the best way possible I think will unfortunately be a fair bit more effort, because you'll need to read the MIME types for every supported format at the beginning of a request, store that state somewhere, then restore it at the end of every master request. Symfony doesn't provide an interface to iterate or read its internal formats mapping, you can only request it either per-format or per-mimetype on Request's public API.

Edit: having gone through a fair portion of the code today and the test suite, I don't think this change introduces any new problems. API Platform is explicit about injecting the preferred format on every request, so the only issue I can identify is the one this fixes, where request formats are being overwritten in long-running servers rather than expanded. I don't think you will see any benefit to any process of resetting the static Request formats on every request.

This is only a mapping of formats to supported MIME types, and the one(s) you're putting in here will always take precedence over the existing formats, which seems like it should be the behaviour you want. Consider:

array_unique(array_merge(['application/problem+json'],['application/json']));

array(2) {
  [0]=>
  string(24) "application/problem+json"
  [1]=>
  string(16) "application/json"
}

array_unique(array_merge(['application/json'],['application/problem+json', 'application/json']));

array(2) {
  [0]=>
  string(16) "application/json"
  [1]=>
  string(24) "application/problem+json"
}

So you should always be getting the right ordering for the format. You can see this PR hasn't broken your test suite, which is a good sign.

definitely a good sign as we have some weird tests in there haha