Skip to content

Fix missing allow attribute #8889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 29, 2024
Merged

Fix missing allow attribute #8889

merged 2 commits into from
Oct 29, 2024

Conversation

abnegate
Copy link
Member

What does this PR do?

(Provide a description of what this PR does and why it's needed.)

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Screenshots may also be helpful.)

Related PRs and Issues

  • (Related PR or issue)

Checklist

  • Have you read the Contributing Guidelines on issues?
  • If the PR includes a change to an API's metadata (desc, label, params, etc.), does it also include updated API specs and example docs?

@abnegate abnegate requested a review from stnguyen90 October 29, 2024 02:24
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 29, 2024 •
edited
Loading

Security Scan Results for PR

Docker Image Scan Results

🎉 No vulnerabilities found!

Source Code Scan Results

🎉 No vulnerabilities found!

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 29, 2024 •
edited
Loading

✨ Benchmark results

  • Requests per second: 1,283
  • Requests with 200 status code: 231,023
  • P99 latency: 0.085348091

⚡ Benchmark Comparison

Metric This PR Latest version
RPS 1,283 2,156
200 231,023 388,105
P99 0.085348091 0.074521714

stnguyen90
stnguyen90 reviewed Oct 29, 2024
View reviewed changes
Copy link
Contributor

@stnguyen90 stnguyen90 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to update the model too? Does it exist in the database table already?

@stnguyen90 stnguyen90 merged commit 894b6f4 into 1.6.x Oct 29, 2024
26 checks passed
@stnguyen90 stnguyen90 deleted the fix-migrations-queries branch October 29, 2024 03:40
@stnguyen90 stnguyen90 mentioned this pull request Oct 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stnguyen90 stnguyen90 stnguyen90 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abnegate @stnguyen90
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy