Skip to content

Are built-in examples on GitHub too? I'd like to propose an improvement to the Fade sketch #5115

@YakovL

Description

@YakovL

Hello Arduino Dev community, I've searched this repo but haven't found, so please guide me where the built-in examples of Arduino IDE are stored and can I propose some improvements?

More specificly, the Fade sketch has these lines:

if (brightness == 0 || brightness == 255) {
  fadeAmount = -fadeAmount ;
}

which I'd say is not a good code as if we change fadeAmount to, say, 7 than we will miss the == 255 value (brightness will rise up to 7*36 = 252 and then will become 259 and will grow further). It should be

if (brightness <= 0 || brightness >= 255) {
  fadeAmount = -fadeAmount ;
}

instead, I would say. So, where do I propose such improvements?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      pFad - Phonifier reborn

      Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

      Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


      Alternative Proxies:

      Alternative Proxy

      pFad Proxy

      pFad v3 Proxy

      pFad v4 Proxy