Print negative numbers as negative numbers regardless of base #4535
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make negative integers be represented with "-" in any base, not just base 10.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Base 10 is not special. Printing a negative number such as -15 in base 16 should show -F, not FFFFFFF1. For the result with the many Fs, the number should be converted to unsigned long (or unsigned int for fewer Fs).
Issue #4460 complains about the behavior of
printfor negative ints (which prints them as unsigned long), and I think the best solution would be to be consistent with what negative integers actually represent rather than with what printf does in C.