core: list return empty array instead of null, when no cores are installed (#2691)

alessio-perugini · web-flow · commit c5812eea68af · 2024-08-13T08:21:28.000+02:00
diff --git a/internal/cli/core/list.go b/internal/cli/core/list.go
@@ -88,9 +88,9 @@ func GetList(ctx context.Context, srv rpc.ArduinoCoreServiceServer, inst *rpc.In
 }
 
 func newCoreListResult(in []*rpc.PlatformSummary, updatableOnly bool) *coreListResult {
-	res := &coreListResult{updatableOnly: updatableOnly}
-	for _, platformSummary := range in {
-		res.Platforms = append(res.Platforms, result.NewPlatformSummary(platformSummary))
+	res := &coreListResult{updatableOnly: updatableOnly, Platforms: make([]*result.PlatformSummary, len(in))}
+	for i, platformSummary := range in {
+		res.Platforms[i] = result.NewPlatformSummary(platformSummary)
 	}
 	return res
 }
diff --git a/internal/integrationtest/core/core_test.go b/internal/integrationtest/core/core_test.go
@@ -1174,6 +1174,7 @@ func TestCoreListWhenNoPlatformAreInstalled(t *testing.T) {
 	stdout, _, err := cli.Run("core", "list", "--json")
 	require.NoError(t, err)
 	requirejson.Query(t, stdout, `.platforms | length`, `0`)
+	requirejson.Query(t, stdout, `.platforms | select(.!=null)`, `[]`)
 
 	stdout, _, err = cli.Run("core", "list")
 	require.NoError(t, err)

Original file line number	Diff line number	Diff line change
`@@ -88,9 +88,9 @@ func GetList(ctx context.Context, srv rpc.ArduinoCoreServiceServer, inst *rpc.In`
`88`	`88`	`}`
`89`	`89`
`90`	`90`	`func newCoreListResult(in []rpc.PlatformSummary, updatableOnly bool) coreListResult {`
`91`		`- res := &coreListResult{updatableOnly: updatableOnly}`
`92`		`- for _, platformSummary := range in {`
`93`		`- res.Platforms = append(res.Platforms, result.NewPlatformSummary(platformSummary))`
	`91`	`+ res := &coreListResult{updatableOnly: updatableOnly, Platforms: make([]*result.PlatformSummary, len(in))}`
	`92`	`+ for i, platformSummary := range in {`
	`93`	`+ res.Platforms[i] = result.NewPlatformSummary(platformSummary)`
`94`	`94`	`}`
`95`	`95`	`return res`
`96`	`96`	`}`