Skip to content

Fix monitor init handling #2728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 11, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix integration test: Allow some time for the mocked-monitor process …
…to terminate

otherwise the test will fail on Windows when the cleanup function tries to remove the
executable:

Error Trace:	D:/a/arduino-cli/arduino-cli/internal/integrationtest/environment.go:46
                D:/a/arduino-cli/arduino-cli/internal/integrationtest/environment.go:56
                D:/a/arduino-cli/arduino-cli/internal/integrationtest/environment.go:56
                D:/a/arduino-cli/arduino-cli/internal/integrationtest/environment.go:62
                D:/a/arduino-cli/arduino-cli/internal/integrationtest/daemon/daemon_concurrency_test.go:127
Error:          Received unexpected error:
                remove C:\Users\runneradmin\AppData\Local\Temp\cli2489057723\A\packages\builtin\tools\serial-monitor\0.14.1\serial-monitor.exe: Access is denied.
Test:           TestInitAndMonitorConcurrency
  • Loading branch information
cmaglie committed Oct 10, 2024
commit a812e1aadbc12546ae862171eb19f77b766fb3f2
5 changes: 5 additions & 0 deletions internal/integrationtest/daemon/daemon_concurrency_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -124,4 +124,9 @@ func TestInitAndMonitorConcurrency(t *testing.T) {
require.LessOrEqual(t, time.Since(start), 4*time.Second)
cancel()
monitorCompleted.Wait()

// Allow some time for the mocked-monitor process to terminate (otherwise the
// test will fail on Windows when the cleanup function tries to remove the
// executable).
time.Sleep(2 * time.Second)
}
Loading
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy