Skip to content

Fixed compiler-cache on Windows when there are non-ASCII characters in file path #2733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 16, 2024
Merged

Fixed compiler-cache on Windows when there are non-ASCII characters in file path #2733

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cae59be
Increased logging during compile
cmaglie Oct 14, 2024
c1b290a
Added integration test
cmaglie Oct 15, 2024
cff613f
Fixed dependency file parsing on Windows
cmaglie Oct 16, 2024
91c7fb3
Fixed panic in convertAnsiBytesToString implementation
cmaglie Oct 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fixed panic in convertAnsiBytesToString implementation
  • Loading branch information
@cmaglie
cmaglie committed Oct 16, 2024
commit 91c7fb39d19a41ea3a8c0ecdae39a1d15c7ea69b
3 changes: 3 additions & 0 deletions internal/arduino/builder/internal/utils/ansi_windows.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,9 @@ import (
)

func convertAnsiBytesToString(data []byte) (string, error) {
if len(data) == 0 {
return "", nil
}
dataSize := int32(len(data))
size, err := windows.MultiByteToWideChar(windows.GetACP(), 0, &data[0], dataSize, nil, 0)
if err != nil {
Expand Down
Loading
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy