Set the extra user agent when a new rpc instance is created

arduino · MatteoPologruto · Jan 23, 2025 · Jan 16, 2025 · Jan 22, 2025 · Jan 22, 2025
commit b7b539986c96593b9b3311ffd8f58e1cb462d7ce
diff --git a/commands/instances.go b/commands/instances.go
@@ -67,6 +67,24 @@ func (s *arduinoCoreServerImpl) Create(ctx context.Context, req *rpc.CreateReque
 	var userAgent string
 	if md, ok := metadata.FromIncomingContext(ctx); ok {
 		userAgent = strings.Join(md.Get("user-agent"), " ")
+		if userAgent != "" {
+			// s.SettingsGetValue() returns an error if the key does not exist and for this reason we are accessing
+			// network.user_agent_ext directly from s.settings.ExtraUserAgent() to set it
+			if s.settings.ExtraUserAgent() == "" {
+				if strings.Contains(userAgent, "arduino-ide/2") {
+					// needed for analytics purposes
+					userAgent = userAgent + " daemon"
+				}
+				_, err := s.SettingsSetValue(ctx, &rpc.SettingsSetValueRequest{
+					Key:          "network.user_agent_ext",
+					ValueFormat:  "cli",
+					EncodedValue: userAgent,
+				})
+				if err != nil {
+					return nil, err
+				}
+			}
+		}
 	}
 
 	// Setup downloads directory