feat(grpc): can set buffer config on monitor open #2975
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ref: arduino/pluggable-monitor-protocol-handler#33 Signed-off-by: dankeboy36 <dankeboy36@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2975 +/- ##
==========================================
+ Coverage 68.26% 68.31% +0.04%
==========================================
Files 241 241
Lines 22703 22724 +21
==========================================
+ Hits 15499 15523 +24
+ Misses 6007 6005 -2
+ Partials 1197 1196 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
See how to contribute
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)configuration.schema.jsonupdated if new parameters are added.What kind of change does this PR introduce?
This PR adds a feature to tune the monitor buffer config when opening the duplex. See why at arduino/pluggable-monitor-protocol-handler#33.
What is the current behavior?
As described in arduino/pluggable-monitor-protocol-handler#33, the Arduino CLI pushes small data chunks from the port to the CLI and down to the clients.
What is the new behavior?
The new feature adds config for the monitor buffer config, such as high watermark, flush interval, and autoflush on line end, and a simple queuing strategy.
Does this PR introduce a breaking change, and is titled accordingly?
No.
Other information