Css/expand line numbers column #149
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Development to Main
Signed-off-by: ubi de feo <me@ubidefeo.com>
sebromero
approved these changes
Dec 5, 2024
There was a problem hiding this comment.
Looks good as a quick fix. I tested it locally. Indeed there is afaik no way to achieve this only with CSS. Even if we would put the tab and the editor view in one column and the gutter + the empty space of the tab bar into one, they would align but the scrolling would be broken.
|
yep, I tried a few ways. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The line numbers column truncated above 3 digits, making it look like numbers after 999 wrapped back to 000.
Because of how the current layout is structured, making this column dynamic would require dynamic alignment of tabs based on the width of this column, so for now the fixed width has been expanded to 60px