Skip to content

Defined TimeoutTable for the user to customize timeouts #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Defined TimeoutTable for the user to customize timeouts #140

wants to merge 1 commit into from

Conversation

andreagilardoni
Copy link
Contributor

@andreagilardoni andreagilardoni commented May 12, 2025 •
edited
Loading

changing the approach from defining a static array CHECK_INTERVAL_TABLE we can allow the user to change timeout values at runtime depending on his needs.

This addresses #139

@andreagilardoni andreagilardoni requested a review from pennam May 12, 2025 13:02
@github-actions GitHub Actions
Copy link

Memory usage change @ e1983a0

Board flash % RAM for global variables %
arduino:esp32:nano_nora 🔺 +8 - +16 0.0 - 0.0 🔺 +24 - +32 +0.01 - +0.01
arduino:mbed:envie_m7 N/A N/A N/A N/A
arduino:mbed_edge:edge_control 🔺 0 - +64 0.0 - +0.01 🔺 +32 - +32 +0.01 - +0.01
arduino:mbed_giga:giga 🔺 +64 - +64 0.0 - 0.0 🔺 +32 - +32 +0.01 - +0.01
arduino:mbed_nano:nanorp2040connect 🔺 +42 - +62 0.0 - 0.0 🔺 +32 - +32 +0.01 - +0.01
arduino:mbed_nicla:nicla_vision 🔺 0 - +64 0.0 - 0.0 🔺 +32 - +32 +0.01 - +0.01
arduino:mbed_opta:opta 🔺 +64 - +64 0.0 - 0.0 🔺 +24 - +32 0.0 - +0.01
arduino:mbed_portenta:envie_m7 N/A N/A N/A N/A
arduino:renesas_portenta:portenta_c33 🔺 +16 - +32 0.0 - 0.0 🔺 +28 - +32 +0.01 - +0.01
arduino:renesas_uno:unor4wifi 🔺 +32 - +48 +0.01 - +0.02 🔺 +28 - +28 +0.09 - +0.09
arduino:samd:mkr1000 🔺 +48 - +56 +0.02 - +0.02 🔺 +28 - +28 +0.09 - +0.09
arduino:samd:mkrgsm1400 🔺 +32 - +56 +0.01 - +0.02 🔺 +28 - +28 +0.09 - +0.09
arduino:samd:mkrnb1500 🔺 +32 - +56 +0.01 - +0.02 🔺 +28 - +28 +0.09 - +0.09
arduino:samd:mkrwan1300 🔺 +24 - +56 +0.01 - +0.02 🔺 +28 - +28 +0.09 - +0.09
arduino:samd:mkrwan1310 🔺 +24 - +64 +0.01 - +0.02 🔺 +28 - +28 +0.09 - +0.09
arduino:samd:mkrwifi1010 🔺 +40 - +56 +0.02 - +0.02 🔺 +28 - +28 +0.09 - +0.09
arduino:samd:nano_33_iot 🔺 +40 - +64 +0.02 - +0.02 🔺 +28 - +28 +0.09 - +0.09
esp32:esp32:esp32 🔺 0 - +8 0.0 - 0.0 🔺 +24 - +24 +0.01 - +0.01
esp8266:esp8266:huzzah 🔺 +16 - +32 0.0 - 0.0 🔺 +32 - +32 +0.04 - +0.04
rp2040:rp2040:rpipicow 🔺 +40 - +48 0.0 - 0.0 🔺 +28 - +28 +0.01 - +0.01
Click for full report table
Board examples/ConnectionHandlerDemo
flash		 % examples/ConnectionHandlerDemo
RAM for global variables		 % examples/CheckInternetAvailabilityDemo
flash		 % examples/CheckInternetAvailabilityDemo
RAM for global variables		 % examples/ConnectionHandlerDemo-Notecard
flash		 % examples/ConnectionHandlerDemo-Notecard
RAM for global variables		 %
arduino:esp32:nano_nora 16 0.0 24 0.01 16 0.0 24 0.01 8 0.0 32 0.01
arduino:mbed:envie_m7 N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A
arduino:mbed_edge:edge_control 0 0.0 32 0.01 0 0.0 32 0.01 64 0.01 32 0.01
arduino:mbed_giga:giga 64 0.0 32 0.01 64 0.0 32 0.01 64 0.0 32 0.01
arduino:mbed_nano:nanorp2040connect 42 0.0 32 0.01 42 0.0 32 0.01 62 0.0 32 0.01
arduino:mbed_nicla:nicla_vision 64 0.0 32 0.01 64 0.0 32 0.01 0 0.0 32 0.01
arduino:mbed_opta:opta 64 0.0 32 0.01 64 0.0 32 0.01 64 0.0 24 0.0
arduino:mbed_portenta:envie_m7 N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A
arduino:renesas_portenta:portenta_c33 16 0.0 32 0.01 24 0.0 32 0.01 32 0.0 28 0.01
arduino:renesas_uno:unor4wifi 32 0.01 28 0.09 48 0.02 28 0.09 32 0.01 28 0.09
arduino:samd:mkr1000 48 0.02 28 0.09 48 0.02 28 0.09 56 0.02 28 0.09
arduino:samd:mkrgsm1400 32 0.01 28 0.09 32 0.01 28 0.09 56 0.02 28 0.09
arduino:samd:mkrnb1500 32 0.01 28 0.09 32 0.01 28 0.09 56 0.02 28 0.09
arduino:samd:mkrwan1300 32 0.01 28 0.09 24 0.01 28 0.09 56 0.02 28 0.09
arduino:samd:mkrwan1310 32 0.01 28 0.09 24 0.01 28 0.09 64 0.02 28 0.09
arduino:samd:mkrwifi1010 40 0.02 28 0.09 40 0.02 28 0.09 56 0.02 28 0.09
arduino:samd:nano_33_iot 40 0.02 28 0.09 40 0.02 28 0.09 64 0.02 28 0.09
esp32:esp32:esp32 0 0.0 24 0.01 0 0.0 24 0.01 8 0.0 24 0.01
esp8266:esp8266:huzzah 16 0.0 32 0.04 32 0.0 32 0.04
rp2040:rp2040:rpipicow 40 0.0 28 0.01 40 0.0 28 0.01 48 0.0 28 0.01
Click for full report CSV 
Board,examples/ConnectionHandlerDemo<br>flash,%,examples/ConnectionHandlerDemo<br>RAM for global variables,%,examples/CheckInternetAvailabilityDemo<br>flash,%,examples/CheckInternetAvailabilityDemo<br>RAM for global variables,%,examples/ConnectionHandlerDemo-Notecard<br>flash,%,examples/ConnectionHandlerDemo-Notecard<br>RAM for global variables,%
arduino:esp32:nano_nora,16,0.0,24,0.01,16,0.0,24,0.01,8,0.0,32,0.01
arduino:mbed:envie_m7,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A
arduino:mbed_edge:edge_control,0,0.0,32,0.01,0,0.0,32,0.01,64,0.01,32,0.01
arduino:mbed_giga:giga,64,0.0,32,0.01,64,0.0,32,0.01,64,0.0,32,0.01
arduino:mbed_nano:nanorp2040connect,42,0.0,32,0.01,42,0.0,32,0.01,62,0.0,32,0.01
arduino:mbed_nicla:nicla_vision,64,0.0,32,0.01,64,0.0,32,0.01,0,0.0,32,0.01
arduino:mbed_opta:opta,64,0.0,32,0.01,64,0.0,32,0.01,64,0.0,24,0.0
arduino:mbed_portenta:envie_m7,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A
arduino:renesas_portenta:portenta_c33,16,0.0,32,0.01,24,0.0,32,0.01,32,0.0,28,0.01
arduino:renesas_uno:unor4wifi,32,0.01,28,0.09,48,0.02,28,0.09,32,0.01,28,0.09
arduino:samd:mkr1000,48,0.02,28,0.09,48,0.02,28,0.09,56,0.02,28,0.09
arduino:samd:mkrgsm1400,32,0.01,28,0.09,32,0.01,28,0.09,56,0.02,28,0.09
arduino:samd:mkrnb1500,32,0.01,28,0.09,32,0.01,28,0.09,56,0.02,28,0.09
arduino:samd:mkrwan1300,32,0.01,28,0.09,24,0.01,28,0.09,56,0.02,28,0.09
arduino:samd:mkrwan1310,32,0.01,28,0.09,24,0.01,28,0.09,64,0.02,28,0.09
arduino:samd:mkrwifi1010,40,0.02,28,0.09,40,0.02,28,0.09,56,0.02,28,0.09
arduino:samd:nano_33_iot,40,0.02,28,0.09,40,0.02,28,0.09,64,0.02,28,0.09
esp32:esp32:esp32,0,0.0,24,0.01,0,0.0,24,0.01,8,0.0,24,0.01
esp8266:esp8266:huzzah,16,0.0,32,0.04,32,0.0,32,0.04,,,,
rp2040:rp2040:rpipicow,40,0.0,28,0.01,40,0.0,28,0.01,48,0.0,28,0.01

@per1234 per1234 added type: enhancement Proposed improvement topic: code Related to content of the project itself labels May 13, 2025
@pennam
Copy link
Contributor

pennam commented May 14, 2025

@andreagilardoni what do you think about adding also another function to just change one interval? Something like

updateTimeoutInterval(NetworkConnectionState state, uint32_t interval);

I think it would be more handy if users have to change only one interval and not the entire table.

@andreagilardoni
Copy link
Contributor Author

It seems to be a good idea, I will add it.

@andreagilardoni
Defined TimeoutTable for the user to customize timeouts
7a9f07b 
changing the approach from defining a static array CHECK_INTERVAL_TABLE
we can allow the user to change timeout values at runtime depending on
his needs.
@github-actions GitHub Actions
Copy link

Memory usage change @ 7a9f07b

Board flash % RAM for global variables %
arduino:esp32:nano_nora 🔺 +8 - +16 0.0 - 0.0 🔺 +24 - +32 +0.01 - +0.01
arduino:mbed:envie_m7 N/A N/A N/A N/A
arduino:mbed_edge:edge_control 🔺 0 - +64 0.0 - +0.01 🔺 +24 - +32 +0.01 - +0.01
arduino:mbed_giga:giga 🔺 +64 - +64 0.0 - 0.0 🔺 +32 - +32 +0.01 - +0.01
arduino:mbed_nano:nanorp2040connect 🔺 +42 - +62 0.0 - 0.0 🔺 +32 - +32 +0.01 - +0.01
arduino:mbed_nicla:nicla_vision 🔺 +64 - +64 0.0 - 0.0 🔺 +32 - +32 +0.01 - +0.01
arduino:mbed_opta:opta 🔺 0 - +64 0.0 - 0.0 🔺 +24 - +32 0.0 - +0.01
arduino:mbed_portenta:envie_m7 N/A N/A N/A N/A
arduino:renesas_portenta:portenta_c33 🔺 +16 - +32 0.0 - 0.0 🔺 +28 - +32 +0.01 - +0.01
arduino:renesas_uno:unor4wifi 🔺 +32 - +48 +0.01 - +0.02 🔺 +28 - +28 +0.09 - +0.09
arduino:samd:mkr1000 🔺 +48 - +56 +0.02 - +0.02 🔺 +28 - +28 +0.09 - +0.09
arduino:samd:mkrgsm1400 🔺 +32 - +56 +0.01 - +0.02 🔺 +28 - +28 +0.09 - +0.09
arduino:samd:mkrnb1500 🔺 +32 - +56 +0.01 - +0.02 🔺 +28 - +28 +0.09 - +0.09
arduino:samd:mkrwan1300 🔺 +24 - +56 +0.01 - +0.02 🔺 +28 - +28 +0.09 - +0.09
arduino:samd:mkrwan1310 🔺 +24 - +64 +0.01 - +0.02 🔺 +28 - +28 +0.09 - +0.09
arduino:samd:mkrwifi1010 🔺 +40 - +56 +0.02 - +0.02 🔺 +28 - +28 +0.09 - +0.09
arduino:samd:nano_33_iot 🔺 +40 - +64 +0.02 - +0.02 🔺 +28 - +28 +0.09 - +0.09
esp32:esp32:esp32 🔺 0 - +8 0.0 - 0.0 🔺 +24 - +24 +0.01 - +0.01
esp8266:esp8266:huzzah 🔺 +16 - +32 0.0 - 0.0 🔺 +32 - +32 +0.04 - +0.04
rp2040:rp2040:rpipicow 🔺 +40 - +48 0.0 - 0.0 🔺 +28 - +28 +0.01 - +0.01
Click for full report table
Board examples/ConnectionHandlerDemo
flash		 % examples/ConnectionHandlerDemo
RAM for global variables		 % examples/CheckInternetAvailabilityDemo
flash		 % examples/CheckInternetAvailabilityDemo
RAM for global variables		 % examples/ConnectionHandlerDemo-Notecard
flash		 % examples/ConnectionHandlerDemo-Notecard
RAM for global variables		 %
arduino:esp32:nano_nora 16 0.0 24 0.01 16 0.0 24 0.01 8 0.0 32 0.01
arduino:mbed:envie_m7 N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A
arduino:mbed_edge:edge_control 64 0.01 24 0.01 64 0.01 24 0.01 0 0.0 32 0.01
arduino:mbed_giga:giga 64 0.0 32 0.01 64 0.0 32 0.01 64 0.0 32 0.01
arduino:mbed_nano:nanorp2040connect 42 0.0 32 0.01 42 0.0 32 0.01 62 0.0 32 0.01
arduino:mbed_nicla:nicla_vision 64 0.0 32 0.01 64 0.0 32 0.01 64 0.0 32 0.01
arduino:mbed_opta:opta 64 0.0 32 0.01 64 0.0 32 0.01 0 0.0 24 0.0
arduino:mbed_portenta:envie_m7 N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A
arduino:renesas_portenta:portenta_c33 16 0.0 32 0.01 24 0.0 32 0.01 32 0.0 28 0.01
arduino:renesas_uno:unor4wifi 32 0.01 28 0.09 48 0.02 28 0.09 32 0.01 28 0.09
arduino:samd:mkr1000 48 0.02 28 0.09 48 0.02 28 0.09 56 0.02 28 0.09
arduino:samd:mkrgsm1400 32 0.01 28 0.09 32 0.01 28 0.09 56 0.02 28 0.09
arduino:samd:mkrnb1500 32 0.01 28 0.09 32 0.01 28 0.09 56 0.02 28 0.09
arduino:samd:mkrwan1300 32 0.01 28 0.09 24 0.01 28 0.09 56 0.02 28 0.09
arduino:samd:mkrwan1310 32 0.01 28 0.09 24 0.01 28 0.09 64 0.02 28 0.09
arduino:samd:mkrwifi1010 40 0.02 28 0.09 40 0.02 28 0.09 56 0.02 28 0.09
arduino:samd:nano_33_iot 40 0.02 28 0.09 40 0.02 28 0.09 64 0.02 28 0.09
esp32:esp32:esp32 0 0.0 24 0.01 0 0.0 24 0.01 8 0.0 24 0.01
esp8266:esp8266:huzzah 16 0.0 32 0.04 32 0.0 32 0.04
rp2040:rp2040:rpipicow 40 0.0 28 0.01 40 0.0 28 0.01 48 0.0 28 0.01
Click for full report CSV 
Board,examples/ConnectionHandlerDemo<br>flash,%,examples/ConnectionHandlerDemo<br>RAM for global variables,%,examples/CheckInternetAvailabilityDemo<br>flash,%,examples/CheckInternetAvailabilityDemo<br>RAM for global variables,%,examples/ConnectionHandlerDemo-Notecard<br>flash,%,examples/ConnectionHandlerDemo-Notecard<br>RAM for global variables,%
arduino:esp32:nano_nora,16,0.0,24,0.01,16,0.0,24,0.01,8,0.0,32,0.01
arduino:mbed:envie_m7,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A
arduino:mbed_edge:edge_control,64,0.01,24,0.01,64,0.01,24,0.01,0,0.0,32,0.01
arduino:mbed_giga:giga,64,0.0,32,0.01,64,0.0,32,0.01,64,0.0,32,0.01
arduino:mbed_nano:nanorp2040connect,42,0.0,32,0.01,42,0.0,32,0.01,62,0.0,32,0.01
arduino:mbed_nicla:nicla_vision,64,0.0,32,0.01,64,0.0,32,0.01,64,0.0,32,0.01
arduino:mbed_opta:opta,64,0.0,32,0.01,64,0.0,32,0.01,0,0.0,24,0.0
arduino:mbed_portenta:envie_m7,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A
arduino:renesas_portenta:portenta_c33,16,0.0,32,0.01,24,0.0,32,0.01,32,0.0,28,0.01
arduino:renesas_uno:unor4wifi,32,0.01,28,0.09,48,0.02,28,0.09,32,0.01,28,0.09
arduino:samd:mkr1000,48,0.02,28,0.09,48,0.02,28,0.09,56,0.02,28,0.09
arduino:samd:mkrgsm1400,32,0.01,28,0.09,32,0.01,28,0.09,56,0.02,28,0.09
arduino:samd:mkrnb1500,32,0.01,28,0.09,32,0.01,28,0.09,56,0.02,28,0.09
arduino:samd:mkrwan1300,32,0.01,28,0.09,24,0.01,28,0.09,56,0.02,28,0.09
arduino:samd:mkrwan1310,32,0.01,28,0.09,24,0.01,28,0.09,64,0.02,28,0.09
arduino:samd:mkrwifi1010,40,0.02,28,0.09,40,0.02,28,0.09,56,0.02,28,0.09
arduino:samd:nano_33_iot,40,0.02,28,0.09,40,0.02,28,0.09,64,0.02,28,0.09
esp32:esp32:esp32,0,0.0,24,0.01,0,0.0,24,0.01,8,0.0,24,0.01
esp8266:esp8266:huzzah,16,0.0,32,0.04,32,0.0,32,0.04,,,,
rp2040:rp2040:rpipicow,40,0.0,28,0.01,40,0.0,28,0.01,48,0.0,28,0.01

@fabik111
Copy link
Contributor

fabik111 commented Jul 1, 2025

@andreagilardoni LGTM, I would add it to the example, what do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pennam pennam Awaiting requested review from pennam

Assignees
No one assigned
Labels
topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@andreagilardoni @pennam @fabik111 @per1234
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy