Skip to content
This repository was archived by the owner on Feb 28, 2024. It is now read-only.

Fix hour alarm register #108

Merged
merged 1 commit into from
Sep 21, 2023
Merged

Fix hour alarm register #108

merged 1 commit into from
Sep 21, 2023

Conversation

marqdevx
Copy link
Member

@marqdevx marqdevx commented Sep 7, 2023

On the function setHourAlarm the register used was PCF8563T_HOUR_REG instead of PCF8563T_HOUR_ALARM_REG

@marqdevx @Hamza-Proline
Fix hour alarm register
ffb18f7 
Co-authored-by: Hamza-Proline <h.benabdeljawed@arduino.cc>
@per1234 per1234 added type: imperfection Perceived defect in any part of project topic: code Related to content of the project itself labels Sep 7, 2023
@github-actions
Copy link

github-actions bot commented Sep 7, 2023

Memory usage change @ ffb18f7

Board flash % RAM for global variables %
arduino:mbed_portenta:envie_m7 N/A N/A N/A N/A
Click for full report table
Board examples/Analog_Out
flash		 % examples/Analog_Out
RAM for global variables		 % examples/Analog_input/Analog_input_0_10V
flash		 % examples/Analog_input/Analog_input_0_10V
RAM for global variables		 % examples/Analog_input/Analog_input_4_20mA
flash		 % examples/Analog_input/Analog_input_4_20mA
RAM for global variables		 % examples/Analog_input/Analog_input_NTC
flash		 % examples/Analog_input/Analog_input_NTC
RAM for global variables		 % examples/CAN/ReadCan
flash		 % examples/CAN/ReadCan
RAM for global variables		 % examples/CAN/WriteCan
flash		 % examples/CAN/WriteCan
RAM for global variables		 % examples/Digital_output
flash		 % examples/Digital_output
RAM for global variables		 % examples/Digital_programmable/CombinedIOExpander
flash		 % examples/Digital_programmable/CombinedIOExpander
RAM for global variables		 % examples/Digital_programmable/Digital_input
flash		 % examples/Digital_programmable/Digital_input
RAM for global variables		 % examples/Digital_programmable/GPIO_programmable
flash		 % examples/Digital_programmable/GPIO_programmable
RAM for global variables		 % examples/Encoders
flash		 % examples/Encoders
RAM for global variables		 % examples/Ethernet
flash		 % examples/Ethernet
RAM for global variables		 % examples/RS232
flash		 % examples/RS232
RAM for global variables		 % examples/RS485_fullduplex
flash		 % examples/RS485_fullduplex
RAM for global variables		 % examples/RS485_halfduplex
flash		 % examples/RS485_halfduplex
RAM for global variables		 % examples/RTC
flash		 % examples/RTC
RAM for global variables		 % examples/RTC_Alarm
flash		 % examples/RTC_Alarm
RAM for global variables		 % examples/Temp_probes_RTD
flash		 % examples/Temp_probes_RTD
RAM for global variables		 % examples/Temp_probes_Thermocouples
flash		 % examples/Temp_probes_Thermocouples
RAM for global variables		 % examples/USB_host
flash		 % examples/USB_host
RAM for global variables		 %
arduino:mbed_portenta:envie_m7 N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A
Click for full report CSV 
Board,examples/Analog_Out<br>flash,%,examples/Analog_Out<br>RAM for global variables,%,examples/Analog_input/Analog_input_0_10V<br>flash,%,examples/Analog_input/Analog_input_0_10V<br>RAM for global variables,%,examples/Analog_input/Analog_input_4_20mA<br>flash,%,examples/Analog_input/Analog_input_4_20mA<br>RAM for global variables,%,examples/Analog_input/Analog_input_NTC<br>flash,%,examples/Analog_input/Analog_input_NTC<br>RAM for global variables,%,examples/CAN/ReadCan<br>flash,%,examples/CAN/ReadCan<br>RAM for global variables,%,examples/CAN/WriteCan<br>flash,%,examples/CAN/WriteCan<br>RAM for global variables,%,examples/Digital_output<br>flash,%,examples/Digital_output<br>RAM for global variables,%,examples/Digital_programmable/CombinedIOExpander<br>flash,%,examples/Digital_programmable/CombinedIOExpander<br>RAM for global variables,%,examples/Digital_programmable/Digital_input<br>flash,%,examples/Digital_programmable/Digital_input<br>RAM for global variables,%,examples/Digital_programmable/GPIO_programmable<br>flash,%,examples/Digital_programmable/GPIO_programmable<br>RAM for global variables,%,examples/Encoders<br>flash,%,examples/Encoders<br>RAM for global variables,%,examples/Ethernet<br>flash,%,examples/Ethernet<br>RAM for global variables,%,examples/RS232<br>flash,%,examples/RS232<br>RAM for global variables,%,examples/RS485_fullduplex<br>flash,%,examples/RS485_fullduplex<br>RAM for global variables,%,examples/RS485_halfduplex<br>flash,%,examples/RS485_halfduplex<br>RAM for global variables,%,examples/RTC<br>flash,%,examples/RTC<br>RAM for global variables,%,examples/RTC_Alarm<br>flash,%,examples/RTC_Alarm<br>RAM for global variables,%,examples/Temp_probes_RTD<br>flash,%,examples/Temp_probes_RTD<br>RAM for global variables,%,examples/Temp_probes_Thermocouples<br>flash,%,examples/Temp_probes_Thermocouples<br>RAM for global variables,%,examples/USB_host<br>flash,%,examples/USB_host<br>RAM for global variables,%
arduino:mbed_portenta:envie_m7,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A

leonardocavagnis
leonardocavagnis approved these changes Sep 21, 2023
View reviewed changes
Copy link
Collaborator

@leonardocavagnis leonardocavagnis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @marqdevx,
Thanks for contribution. The fix is correct.

@leonardocavagnis leonardocavagnis merged commit ca7ff9b into arduino-libraries:master Sep 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
1 more reviewer

@leonardocavagnis leonardocavagnis leonardocavagnis approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marqdevx @leonardocavagnis @per1234
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy