Update mocha #9
Open
Update mocha #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
there we 2 vulnerabilities found before the update: ``` $ npm audit Run npm install --save-dev mocha@10.0.0 to resolve 2 vulnerabilities found 2 vulnerabilities (1 moderate, 1 critical) in 25 scanned packages 2 vulnerabilities require semver-major dependency updates. ```
ariya
approved these changes
May 22, 2022
|
hmm, looks like we have to drop support for Node.js <= 10. |
|
Yes, I can see some tests are failing @ariya |
as the tests are failing on these versions because we update mocha.
|
Oups, tests legacy 6.x also failing. Should we delete this too @ariya ? |
yes. |
as it's no longer support node.js < 12
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
there we 2 vulnerabilities found before the update: