Version 3 #52
Version 3 #52
Conversation
|
I git-renamed all the files properly, however due to some files being changed too much (> 50%), git sees it as a |
|
Hi @pkruithof You did a great job. Let me few hours to review it before merging. Regards; |
|
Good luck 😉 By the way, the |
Version 3 - thanks for @pkruithof
|
I've trusted your work quickly. I haven't take a look on each part of your PR. Also, Thanks for this huge work ;) |
|
Nice! We're using a lot of worker functionality in our projects, I'll upgrade one of them soon to this new version, that way it's tested in real life 😃 |
| xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" | ||
| xsi:schemaLocation="http://symfony.com/schema/dic/services http://symfony.com/schema/dic/services/services-1.0.xsd"> | ||
| <parameters> | ||
| <parameter key="leezy.pheanstalk.command.abstract.class">Leezy\PheanstalkBundle\Command\AbstractPheanstalkCommand</parameter> |
There was a problem hiding this comment.
Hi @armetiz.
What you think about adopting this proposal in "leezy/pheanstalk-bundle": "~3.0"?
There was a problem hiding this comment.
I agree with this proposal; Do you want to make a PR ?
There was a problem hiding this comment.
Good @armetiz. Yes, I guess I'll send you a PR today.
Thank you.
Sorry in advance for the long PR description 😉
This weekend I noticed that Pheanstalk has reached version 3, but this bundle limits the dependency to
<3.0. This was the right choice as Pheanstalk now properly uses namespaces. However with that library moving forward I think it's a good idea to upgrade this bundle as well.As the namespaces of Pheanstalk have changed, this could cause breaking changes in projects that use this bundle, if they use any of the Pheanstalk classes directly. Granted, projects should include Pheanstalk as a dependency if they do this, but I think practically it would be best if this bundle's new version is also a major one.
Hence I've been working on what I think should be v3 of this bundle. I left the code mostly unchanged, except for some minor details. However I did make some decisions which I feel I should explain here, so here goes:
/src, all tests in/tests, like many projects/libraries do these days. It looks much more clean and organised now in my opinion.PheanstalkLogListenerTestwas not really testing anything before, it is now.PheanstalkTesthas been removed, as it tested Pheanstalk classes, which is outside of the scope of this bundle.That's it, hope you like it ;)