Skip to content

Remove whitespace and a comment that is no longer true #2100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 13, 2025

Conversation

bernardosulzbach
Copy link
Contributor

@bernardosulzbach bernardosulzbach commented Jul 13, 2025

On a separate note, do we still want to try switching to 𐀀 (U+10000) as per #2086 (comment) or some other Unicode scalar value that is not as popular as µ?

Summary by CodeRabbit

  • Documentation
    • Fixed a minor formatting issue in a documentation comment for output arguments.
    • Removed outdated explanatory comments regarding Unicode identifier limitations in C and C++ parsers.

Copy link
Contributor

coderabbitai bot commented Jul 13, 2025

Walkthrough

The changes consist of minor documentation updates: correcting formatting in a struct comment and removing outdated explanatory comments regarding parser limitations. No code logic, control flow, or public API declarations were altered.

Changes

File(s) Change Summary
crates/cli/src/utils/args.rs Fixed formatting in documentation comment for OutputArgs.
crates/language/src/lib.rs Removed two outdated explanatory comment lines.

Poem

In the warren where code is neat,
We tidied docs and skipped a beat.
No logic changed, just comments trimmed,
Our codebase now is slightly primmed.
🐇✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between cbb2ac2 and 7b01536.

📒 Files selected for processing (2)
  • crates/cli/src/utils/args.rs (1 hunks)
  • crates/language/src/lib.rs (0 hunks)
💤 Files with no reviewable changes (1)
  • crates/language/src/lib.rs
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: HerringtonDarkholme
PR: ast-grep/ast-grep#1497
File: crates/cli/src/utils/worker.rs:92-96
Timestamp: 2024-10-08T18:41:57.037Z
Learning: The behavior related to path handling in issue https://github.com/ast-grep/ast-grep/issues/1343 is not determined yet, so we should keep the existing code as is.
Learnt from: HerringtonDarkholme
PR: ast-grep/ast-grep#1497
File: crates/cli/src/utils/worker.rs:92-96
Timestamp: 2024-09-29T22:02:55.187Z
Learning: The behavior related to path handling in issue https://github.com/ast-grep/ast-grep/issues/1343 is not determined yet, so we should keep the existing code as is.
crates/cli/src/utils/args.rs (5)
Learnt from: HerringtonDarkholme
PR: ast-grep/ast-grep#1546
File: crates/cli/src/utils/rule_overwrite.rs:118-121
Timestamp: 2024-10-22T13:56:44.052Z
Learning: The `OverwriteResult` struct in `crates/cli/src/utils/rule_overwrite.rs` will have more override options added in the future, so it should be retained even if it currently only contains an `Option<Severity>`.
Learnt from: HerringtonDarkholme
PR: ast-grep/ast-grep#1546
File: crates/cli/src/utils/rule_overwrite.rs:76-91
Timestamp: 2024-10-22T14:04:15.734Z
Learning: In the `ast-grep-cli` application code, avoid unnecessary abstractions; functions don't need to accept iterators instead of `Vec` if not required.
Learnt from: HerringtonDarkholme
PR: ast-grep/ast-grep#843
File: crates/config/src/fixer.rs:167-181
Timestamp: 2024-10-08T18:41:57.037Z
Learning: The `expand_end` function in `crates/config/src/fixer.rs` should return `node.range().end` instead of `node.range().start` to correctly calculate the end of the range.
Learnt from: HerringtonDarkholme
PR: ast-grep/ast-grep#843
File: crates/config/src/fixer.rs:167-181
Timestamp: 2024-07-27T01:25:27.298Z
Learning: The `expand_end` function in `crates/config/src/fixer.rs` should return `node.range().end` instead of `node.range().start` to correctly calculate the end of the range.
Learnt from: HerringtonDarkholme
PR: ast-grep/ast-grep#1497
File: crates/cli/src/utils/mod.rs:174-175
Timestamp: 2024-09-29T21:59:50.675Z
Learning: ast-grep requires Rust 1.65 or newer. It's acceptable to use syntax and features introduced in Rust 1.65 or newer in ast-grep code.
🔇 Additional comments (1)
crates/cli/src/utils/args.rs (1)

129-129: Whitespace-only change acknowledged—no concerns.
Purely cosmetic doc comment fix; no functional impact.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@HerringtonDarkholme
Copy link
Member

thanks

@HerringtonDarkholme HerringtonDarkholme added this pull request to the merge queue Jul 13, 2025
Merged via the queue into ast-grep:main with commit 3aee799 Jul 13, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy