fix(starlette_client): remove default= keyword from config.get calls #770
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution. I am not sure why, but your patch causes the CI to fail. |
Authlib's Starlette integration was calling self.config.get(conf_key, default=None), which raises a TypeError when config is a plain dict. Changed all occurrences to use the positional form self.config.get(conf_key, None) so that both dicts and Config objects work seamlessly.
836e305 to
3e658d1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Authlib's Starlette integration was calling self.config.get(conf_key, default=None), which raises a TypeError when config is a plain dict. Changed all occurrences to use the positional form self.config.get(conf_key, None) so that both dicts and Config objects work seamlessly.
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
Yes
No
You consent that the copyright of your pull request source code belongs to Authlib's author.