Add analyse level full #291
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 2, 2016 18:44
… stream And compute the exact number of frames.
added 13 commits
November 21, 2016 11:58
…into addAnalyseLevelFull
Use the number of decoded frames in analyseGopStructure method.
* Add log. * Avoid complicate if/else...
From the number of frames and the fps.
…e of full analysis
The current frame is already decoded when we call the callback.
And show the progress.
2 similar comments
2 similar comments
2 similar comments
valnoel
reviewed
Nov 22, 2016
| VideoFrame frame(VideoFrameDesc(getWidth(), getHeight(), getPixelFormatName(getPixelProperties().getAVPixelFormat())), false); | ||
|
|
||
| _nbFrames = nbDecodedFrames; |
There was a problem hiding this comment.
Does this have a real sense to set the number of images with the GOP image number?
|
|
||
| // Returns at the beginning of the stream | ||
| const_cast<InputFile&>(_fileProperties->getInputFile()).seekAtFrame(0, AVSEEK_FLAG_BYTE); | ||
| } |
There was a problem hiding this comment.
Shouldn't we use a switch statement here? We might have this const_cast<InputFile&>(_fileProperties->getInputFile()).seekAtFrame(0, AVSEEK_FLAG_BYTE); line twice, but it could be clearer, don't you think?
There was a problem hiding this comment.
Something like that? ad44be7
| LOG_INFO("Need a deeper analysis: see eAnalyseLevelFirstGop.") | ||
| return 0; | ||
| } | ||
| else |
There was a problem hiding this comment.
Humm... I think it is ;)
There was a problem hiding this comment.
Well, you changed it into the getDuration() method, but not into this getNbFrames()!
| LOG_INFO("Need a deeper analysis: see eAnalyseLevelFirstGop.") | ||
| return 0; | ||
| } | ||
| else |
Use a switch statement instead of several if.
Else statement was not necessary!
5 similar comments
2 similar comments
Else statement was not necessary!
4 similar comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I compiled ffmpeg-2.7.7 and avTranscoder in release mode without any specific options, and I get 1min of process to decode and compute all the properties (bitrate, duration, nbFrames) of an AVC stream of 3min (stored in local).