Video/AudioDecoder: fix the codec state when calling decoder destructor #296
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To be able to close a codec from outside of the class without calling ffmpeg/libav methods.
added 2 commits
January 18, 2017 17:13
* The decoder can open the codec (and so there is a flag _isSetup to check this). * If the codec was open by the decoder, it should close it at the end of its life. * So the codec itself is not responsible to close its context.
The StreamTranscoders have to be destroy (close codec included) before removing the InputFiles (streams).
4d19e67 to
aa9387e
Compare
|
Some tests did not pass because the objects were not destroyed in the correct order (since the decoders are responsible to close the codecs). The last commits should fix this issue. Waiting the results of CI... |
* Force to call the reader destructor before the inputFile destructor (which cannot happen in C++). * This is a new problem since the decoder has a link to the stream, which is needed to access the codec to close it. So the file, which handles the streams, should not be destroyed before the decoders.
2 similar comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes our paddef issue XDMAT-525.