Skip to content

Corrected dead link in the README.md #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 26, 2019
Merged

Corrected dead link in the README.md #164

merged 1 commit into from
Jun 26, 2019

Conversation

ptcrash
Copy link
Contributor

@ptcrash ptcrash commented Jun 21, 2019

Issue #, if available:

Description of changes:
Corrected a dead link to Laravel Service Containers in the README.

Laravel has changed IoC containers to just Service Containers in version ^5.0 of the framework. I've corrected the link to point to the correct documentation here:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@ptcrash
Copy link
Contributor Author

ptcrash commented Jun 21, 2019

Looks like composer failed for the CI check @ PHP v5.5.9

It's strange because I get an HTTP 200 going to the json file that composer says it a 404 on. Maybe re-running the job will clear it up? My contrib doesn't even change code, so... lol

@srchase srchase merged commit d4e5267 into aws:master Jun 26, 2019
@srchase
Copy link

srchase commented Jun 26, 2019

@ptcrash

Thanks for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy