Laravel 7 Support #181
Laravel 7 Support #181
Conversation
|
You'll need to allow phpdotenv v4 otherwise the testsuite won't install laravel 7 ever. |
|
@GrahamCampbell Thanks! |
|
NB #180 |
|
@GrahamCampbell green build finally :D |
|
Is there any update on this? |
|
I don't know, the build is green and no changes have been requested, so I guess we wait until someone with the ability to merge this PR needs Laravel 7 support. |
|
Was hoping this would be merged by this morning. Eta? |
|
@GrahamCampbell would you mind taking another look and see if it's all good? |
|
Don't intend to pressure. But any ETA on getting this merged and tagged @GrahamCampbell ? 😀 |
|
No idea. I don't work for Amazon... |
|
Do any of the Travis runs actually test on Laravel 6 now? It looks like just some 5.x versions and 7.x. |
|
@matthewnessworthy Thanks for the PR. I think @GrahamCampbell brought up a good point about having at least one build on Laravel 6. This can be specified directly in the |
|
Testing on lumen 7 will require dev minimum stability too. |
|
Build is green, travis caching works, php/laravel/lumen version matric appears to work |
.travis.yml
Outdated
| @@ -1,38 +1,52 @@ | |||
| dist: trusty | |||
|
|
|||
| language: php | |||
| sudo: false | |||
There was a problem hiding this comment.
This line can be deleted?
There was a problem hiding this comment.
it's been there since before this PR
There was a problem hiding this comment.
Yeh, but it should still be removed.
|
Could you update the description to include the following text: Closes #171. Closes #178. |
|
@howardlopez would you mind taking a look and merging/tagging if it meets your approval? |
Issue: #178
Description of changes:
Add support for Laravel 7
Closes #171. Closes #178.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.