-
Notifications
You must be signed in to change notification settings - Fork 444
refactor(parser): Improve DynamoDB models with examples and descriptions #7146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(parser): Improve DynamoDB models with examples and descriptions #7146
Conversation
…ields in DynamoDB parser models
Thanks a lot for your first contribution! Please check out our contributing guidelines and don't hesitate to ask whatever you need. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @sreejaaryahi18 this is a super nice work, thanks a lot for working on this! I just left some few comments that we need to address before merging it.
Please let me know if you need any additional help
Hey @sreejaaryahi18 can you please run |
Hey @leandrodamascena Ive made the changes, could you check its right now? |
Thanks for addressing all the feedback! I'll review tomorrow! |
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #7146 +/- ##
========================================
Coverage 96.35% 96.35%
========================================
Files 275 275
Lines 12980 12980
Branches 965 965
========================================
Hits 12507 12507
Misses 366 366
Partials 107 107 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @sreejaaryahi18 thanks a lot for working on this PR!
APPROVED!
Awesome work, congrats on your first merged pull request and thank you for helping improve everyone's experience! |
Issue number: #7123
Summary
Added description and examples parameters to all fields in DynamoDB parser models (aws_lambda_powertools/utilities/parser/models/dynamodb.py) using Field().
These additions provide detailed explanations and realistic example values based on AWS DynamoDB official documentation and sample event.
Changes
User experience
Before this update, the DynamoDB parser models lacked descriptive metadata and examples, making it harder for users to understand field purposes and expected values.
After this update, developers will have clearer, documented field descriptions and example values that improve usability, reduce confusion, and enhance validation confidence when working with DynamoDB stream events
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
NoRFC issue number:
#7123
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.