[babel 8] Remove unnecessary CJS ESM wrapper #17261
Merged
+30
−109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/59206 |
51e4df2 to
0ae6639
Compare
0ae6639 to
867a9c4
Compare
liuxingbaoyu
approved these changes
Apr 25, 2025
JLHwung
approved these changes
Apr 25, 2025
| "The `types` export of @babel/core is only accessible from" + | ||
| " the CommonJS version after that the ESM version is loaded.", | ||
| ); | ||
| await expect(run("eager-plugin-required.cjs")).resolves.not.toThrow(); |
There was a problem hiding this comment.
This test should be updated to the inline snapshot similar to other sub tests here.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1, Fixes #2All Node.js version supported by Babel 8 support
require(esm).Note that the e2e "babel 7 plugins with babel 8 core" is affected by the bug fixed by nodejs/node#57187. That is only in our tests, and not in the actual Babel code.