checkexpr: [minor] move node specific logic into visit (python#9648)

hauntsaninja · web-flow · commit 7c6df795f86d · 2020-10-27T20:56:10.000Z
The has_uninhabited_component was formerly there to avoid clobbering the
store_type call in find_partial_type_ref_fast_path. But this interaction
is avoided by making the store_type call earlier.

Co-authored-by: hauntsaninja &lt;&gt;
diff --git a/mypy/checkexpr.py b/mypy/checkexpr.py
@@ -2849,6 +2849,7 @@ def visit_assignment_expr(self, e: AssignmentExpr) -> Type:
         value = self.accept(e.value)
         self.chk.check_assignment(e.target, e.value)
         self.chk.check_final(e)
+        self.chk.store_type(e.target, value)
         self.find_partial_type_ref_fast_path(e.target)
         return value
 
@@ -3903,9 +3904,6 @@ def accept(self,
         assert typ is not None
         self.chk.store_type(node, typ)
 
-        if isinstance(node, AssignmentExpr) and not has_uninhabited_component(typ):
-            self.chk.store_type(node.target, typ)
-
         if (self.chk.options.disallow_any_expr and
                 not always_allow_any and
                 not self.chk.is_stub and
