Skip to content

checkexpr: [minor] move node specific logic into its visit #9648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 27, 2020
Merged

checkexpr: [minor] move node specific logic into its visit #9648

merged 1 commit into from
Oct 27, 2020
+1 −3

Conversation

hauntsaninja
Copy link
Collaborator

The has_uninhabited_component was formerly there to avoid clobbering the
store_type call in find_partial_type_ref_fast_path. But this interaction
is avoided by making the store_type call earlier.

checkexpr: [minor] move node specific logic into visit
1422af6 
The has_uninhabited_component was formerly there to avoid clobbering the
store_type call in find_partial_type_ref_fast_path. But this interaction
is avoided by making the store_type call earlier.
@hauntsaninja hauntsaninja changed the title checkexpr: [minor] move node specific logic into visit checkexpr: [minor] move node specific logic into its visit Oct 27, 2020
JukkaL
JukkaL approved these changes Oct 27, 2020
View reviewed changes
Copy link
Collaborator

@JukkaL JukkaL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't fully follow what is going on, but test are passing and it's good to move code away from accept() which is a very hot function.

@JukkaL JukkaL merged commit 7c6df79 into python:master Oct 27, 2020
@hauntsaninja hauntsaninja deleted the chkp branch October 27, 2020 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JukkaL JukkaL JukkaL approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hauntsaninja @JukkaL
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy