-
-
Notifications
You must be signed in to change notification settings - Fork 610
Comparing changes
Open a pull request
base repository: bazel-contrib/rules_python
base: main
head repository: bazel-contrib/rules_python
compare: release/1.5
- 6 commits
- 16 files changed
- 3 contributors
Commits on Jun 14, 2025
-
Fix argument name typo (#2984)
``` ERROR: Traceback (most recent call last): File ".../rules_python++pip+rules_mypy_pip_312_click/BUILD.bazel", line 5, column 20, in <toplevel> whl_library_targets( File ".../rules_python+/python/private/pypi/whl_library_targets.bzl", line 337, column 53, in whl_library_targets "//conditions:default": create_inits( File ".../rules_python+/python/private/pypi/namespace_pkgs.bzl", line 72, column 25, in create_inits for out in get_files(**kwargs): File ".../rules_python+/python/private/pypi/namespace_pkgs.bzl", line 20, column 5, in get_files def get_files(*, srcs, ignored_dirnames = [], root = None): Error: get_files() got unexpected keyword argument: ignore_dirnames (did you mean 'ignored_dirnames'?) ``` (cherry picked from commit 94e08f7)
Configuration menu - View commit details
-
Copy full SHA for 379bef5 - Browse repository at this point
Copy the full SHA 379bef5View commit details
Commits on Jun 17, 2025
-
fix: use platform_info.target_settings in toolchain aliases (#3001)
During the refactor we forgot one more place where the `flag_values` on the platform information was used. They were no longer populated and broke. The solution is to use `selects.config_setting_group` to maintain behaviour and in order to smoke test I have added a target to verify that the aliases work. Related to #2875 Fixes #2993 Co-authored-by: Richard Levasseur <richardlev@gmail.com> (cherry picked from commit 107a878)
Configuration menu - View commit details
-
Copy full SHA for a89ec64 - Browse repository at this point
Copy the full SHA a89ec64View commit details
Commits on Jun 20, 2025
-
fix(toolchains): use posix-compatible exec -a alternative (#3010)
The `exec -a` command doesn't work in dash, the default shell for Ubuntu/debian. To work around, use `sh -c`, which is posix and dash compatible. This allows changing the argv0 while invoking a different command. Also adds a test to verify the the runtime_env toolchain works with bootstrap script. Fixes #3009 (cherry picked from commit c4543cd)
Configuration menu - View commit details
-
Copy full SHA for 528181a - Browse repository at this point
Copy the full SHA 528181aView commit details
Commits on Jun 25, 2025
-
fix(pypi): namespace_pkgs should pass correct arguments (#3026)
It seems that the only function that did not have unit tests have bugs and the integration tests did not catch it because we weren't creating namespacepkg `__init__.py` files. This change fixes the bug, adds a unit test for the remaining untested function. Fixes #3023 Co-authored-by: Richard Levasseur <richardlev@gmail.com> (cherry picked from commit 4978027)
Configuration menu - View commit details
-
Copy full SHA for a1ca1da - Browse repository at this point
Copy the full SHA a1ca1daView commit details
Commits on Jun 26, 2025
-
fix: work around version parsing by only parsing if site-packages is …
…enabled (#3031) There's a bug in the version string parser that doesn't handle local identifiers correctly. Thankfully, it's only activated in the experimental code path when site packages for libraries is eanbled. Moving the logic within that block works around it. Work around for #3030 (cherry picked from commit aab2650)
Configuration menu - View commit details
-
Copy full SHA for 63841ec - Browse repository at this point
Copy the full SHA 63841ecView commit details
Commits on Jul 6, 2025
-
fix(pypi): only generate namespace package shims if implicit namespac…
…es are disabled (#3059) The refactoring to move the pkgutil shim generation to build phase inverted the logic for when it should be activated. When `enable_implicit_namespace_pkgs=True`, it means to not generate the pkgutil shims ("respect the Python definition of the namespace package"). To fix, just invert the logic that activates it. A test will be added in a subsequent PR because the necessary helper isn't in the 1.5 branch. Fixes #3038 --------- Co-authored-by: Ignas Anikevicius <240938+aignas@users.noreply.github.com> (cherry picked from commit 47c681b)
Configuration menu - View commit details
-
Copy full SHA for 18d0d29 - Browse repository at this point
Copy the full SHA 18d0d29View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff main...release/1.5