Skip to content

fix: ensure 'patches' attr is included for the canonical representation of the toolchain #1018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 26, 2023
Merged

fix: ensure 'patches' attr is included for the canonical representation of the toolchain #1018

merged 1 commit into from
Jan 26, 2023

Conversation

mattem
Copy link
Contributor

@mattem mattem commented Jan 26, 2023

Fixes the logspew I introduced in #1004

Before:

DEBUG: Rule 'python3_8_x86_64-unknown-linux-gnu' indicated that a canonical reproducible form can be obtained by dropping arguments ["patches"]
DEBUG: Repository python3_8_x86_64-unknown-linux-gnu instantiated at:
  /cache/repo/WORKSPACE:344:27: in <toplevel>
  /cache/bazel/6fadd30f776596320f945376fa05bc65/external/rules_python/python/repositories.bzl:300:26: in python_register_toolchains
Repository rule python_repository defined at:
  /cache/bazel/6fadd30f776596320f945376fa05bc65/external/rules_python/python/repositories.bzl:204:36: in <toplevel>

After:

@mattem mattem requested review from alexeagle and f0rmiga January 26, 2023 15:21
@alexeagle alexeagle merged commit fa3e2d5 into main Jan 26, 2023
@alexeagle alexeagle deleted the spew branch January 26, 2023 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexeagle alexeagle alexeagle approved these changes

@f0rmiga f0rmiga Awaiting requested review from f0rmiga

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattem @alexeagle
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy