Skip to content

fix(local-toolchains): don't watch non-existent include directory #3048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

rickeylev
Copy link
Collaborator

Apparently, Macs can mis-report their include directory.

Since includes are only needed if C extensions are built, skip watching the directory
if it doesn't exist.

Work around for #3043

google-labs-jules bot and others added 2 commits July 2, 2025 23:58
The local_runtime_repo rule was failing on macOS when the Python interpreter's metadata pointed to an include directory that did not exist. This change modifies the rule to check if the include directory exists and is a directory before attempting to watch it with `watch_tree`.
@rickeylev rickeylev requested a review from aignas as a code owner July 3, 2025 00:07
@rickeylev rickeylev enabled auto-merge July 3, 2025 02:45
@rickeylev rickeylev added this pull request to the merge queue Jul 4, 2025
Merged via the queue into bazel-contrib:main with commit be55942 Jul 4, 2025
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy