docs: Add note about Python 3.9 to CHANGELOG.md #3052
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is it enough to add it to the 1.5.0 section given that it was already released? Can the release notes be edited? |
rickeylev
approved these changes
Jul 3, 2025
|
yes, it's fine to add something retroactively. They won't show up in the published 1.5 docs unless we backport it to that branch and rebuild the docs. I'm not sure if that requires tagging (and thus a new release), though. So we'll probably just leave the 1.5 docs published as-is |
amartani
pushed a commit
to benchling/rules_python
that referenced
this pull request
Jul 8, 2025
rules_python 1.5.0 upgraded its internal setuputils to 78.1.1 which has a minimum supported Python version of 3.9. Using this version with Python 3.8 leads to errors (see below) although for some reason, I only see them on Linux builds, not Mac. Since Python 3.8 is EOL, document that Python 3.8 will no longer work due to this setuptools version. Fixes bazel-contrib#3050 --------- Co-authored-by: Richard Levasseur <richardlev@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rules_python 1.5.0 upgraded its internal setuputils to 78.1.1 which has a minimum supported Python version of 3.9. Using this version with Python 3.8 leads to errors (see below) although for some reason, I only see them on Linux builds, not Mac.
Since Python 3.8 is EOL, document that Python 3.8 will no longer work due to this setuptools version.
Fixes #3050