feat: Add windows arm64 python toolchains #3062
Conversation
The changelog for astral-sh/python-build-standalone release 20250630 says: * Add ARM64 Windows builds for Python 3.11+ Lets use them! Signed-off-by: Austin Schuh <austin.linux@gmail.com>
There was a problem hiding this comment.
Thanks for the PR, almost LGTM.
Please update "3.9" and "3.10" to use the same latest release. Usually they include security and other fixes, so a subset of versions from the release is not what we normally do.
And please change the existing changelog message about the toolchain bump. The users won't see 3.14.0b2 and the previous toolchain bump, so best to have one entry that they can read.
Update the version checksum script to output a format which is easy to copy into versions.bzl
|
Done! That's an easy and reasonable request. I updated |
|
Yes please, reverting the formatting would be easier because I have a PR for that ready. |
It seems that in bazel-contrib#3062 we did not notice that the latest builds for `linux-aarch64-freethreaded` actually needed a different build tag and this is the case only for the latest releases. What is more, the `windows-aarch64` build had a wrong strip-prefix. This is fixing all of these issues. bazel-contrib#3028 will make the 404 error messages from `curl` more visible, so the first issue will be more easily caught during authoring, whereas the second issue is going to be more likely caught via code review, or a CI that is exercising the actual toolchains.
It seems that in #3062 we did not notice that the latest builds for `linux-aarch64-freethreaded` actually needed a different build tag and this is the case only for the latest releases. What is more, the `windows-aarch64` build had a wrong strip-prefix. This is fixing all of these issues. #3028 will make the 404 error messages from `curl` more visible, so the first issue will be more easily caught during authoring, whereas the second issue is going to be more likely caught via code review, or a CI that is exercising the actual toolchains.
The changelog for astral-sh/python-build-standalone release 20250630 says:
Lets use them! This is helpful when using rules_python on arm64 windows
Work towards #2276