I saw windows errors had mixed path separators and I wonder if using the bazel skylib helper is causing this.

Maybe trying out os.path.norm would be also an option - the path does not have to exist for it to work, so I think it may be still OK.

I saw windows errors had mixed path separators and I wonder if using the bazel skylib helper is causing this.

Did you get an error when trying this change? Was the error specific to Windows? Did it work for you on another platform? Would you mind sharing the error message?

Maybe trying out os.path.norm would be also an option - the path does not have to exist for it to work, so I think it may be still OK.

I don't think I understand. Can you elaborate on what you mean by, "the path does not have to exist for it to work"? Are you referring to the path to the stub? If it doesn't exist, wouldn't that cause a fatal error?

See the errors in the CI: https://buildkite.com/organizations/bazel/pipelines/rules-python-python/builds/12251/jobs/01981aa5-6b45-4c43-b5bd-8d6dfc408065/artifacts/01981aab-bc3b-4fae-a258-79dd924dfb80

In my tests

p = "a/../b"
os.norm.path(p) # returns "b"

pathlib.Path(p).resolve # returns absolute path

I meant that p does not have to exist on the filesystem for os.norm.path to work the way we want. Obviously for everything to work it will have to be present on the filesystem, but it should be a relative path and not an absolute if we want to pass it to the runfiles library.

Understood. Thanks for the reply! I've added another commit which switches to using Python's normpath(). Let's see if the tests work now.

I've also tried to clean up the mess I made when I committed the tab completion fix to this same branch. Hopefully everything is better now.