fix: repl tab completion #3114
Open
fix: repl tab completion #3114
+44
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think #3104 needs to merged into this so that the |
6ee1b0f to
e3dbb91
Compare
e3dbb91 to
991fbab
Compare
I believe I've gotten that merge done. I'm surprised by the CI failures. They make it look like the merge wasn't successful, but the content of the commit the tests used looks correct to me. |
philsc
added a commit
to philsc/rules_python
that referenced
this pull request
Jul 28, 2025
I noticed that the CI error messages for bazel-contrib#3114 are not useful. This patch aims to help with that by printing the output of the REPL code. If there's an exception during startup for example, then the test log will now contain the stack trace.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 1, 2025
I noticed that the CI error messages for #3114 are not useful. This patch aims to help with that by printing the output of the REPL code. If there's an exception during startup for example, then the test log will now contain the stack trace. --------- Co-authored-by: Ignas Anikevicius <240938+aignas@users.noreply.github.com>
|
I'm seeing more clear error messages now. It seems the |
The readline module is not avialable on all platforms.
aignas
reviewed
Aug 2, 2025
This commit also makes an attempt to minimize the amount of code within the `try` block for importing `realine`.
aignas
reviewed
Aug 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds tab completion to the default stub when using the REPL feature.