This repository was archived by the owner on Feb 22, 2024. It is now read-only.
Add blue/green deployment #3291
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't want to break the current release pipeline, the whole "for.." section in k8s_deploy will be deleted after manually switch traffic to AWS EKS blue/green deployment and change staging DNS from Alicloud cluster to AWS EKS
ghost
approved these changes
May 28, 2021
There was a problem hiding this comment.
Looks good to me.
There's a few things I hadn't spotted before, like SERVER_ID and the use of latest.
Those are distractions to your primary goal here though, which looks good.
I'd maybe have split apart what you're doing into some atomic commits for the non-critical changes to achieve the purpose, e.g. the changes to parameters.
But great work 🎉
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't want to break the current release pipeline, the whole "for.." section in k8s_deploy
will be deleted after manually switch traffic to AWS EKS blue/green deployment
and change staging DNS from Alicloud cluster to AWS EKS
Fixes #1, Fixes #2