This repository was archived by the owner on Feb 22, 2024. It is now read-only.
Sort log info to display the latest trade at the top #3588
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sara-fs
reviewed
Apr 25, 2022
src/botPage/view/shared.js
Outdated
| @@ -36,6 +36,17 @@ export const appendRow = (trade, state) => ({ | |||
| ], | |||
| }); | |||
|
|
|||
| export const appendRowTop = (trade, state) => ({ | |||
There was a problem hiding this comment.
Since we are repeating codes in this method and the codes above, is there a better way to mix them?
There was a problem hiding this comment.
We can maybe mix them with conditional rendering using ternary operators.
There was a problem hiding this comment.
Good job, I think we can only decide on ...state.rows, ...
Whatever you think is better
mehrzad-fs
approved these changes
Apr 26, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.