This repository was archived by the owner on Feb 22, 2024. It is now read-only.
fix for smartcharts and google drive issigned in #3707
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
prince-deriv
reviewed
Aug 8, 2022
Comment on lines
60
to
61
| this.auth = gapi?.auth2?.getAuthInstance?.(); | ||
| if (this?.auth) { |
There was a problem hiding this comment.
If this.auth has already been assigned in the upper line,
do we still need the ? marker for this.?auth
There was a problem hiding this comment.
yes i will remove the question its not required 👍
sandeep-deriv
approved these changes
Aug 8, 2022
habib-deriv
approved these changes
Aug 8, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.