"SameSite" cookie feature (from issue #982) #983
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a reasonable workaround. Thanks :) We just have to remember adding a feature-gate as soon as python supports this natively. |
|
It was my pleasure.. (= I'm watching the open pull request anyway, so i'll have that in mind if the time has come. |
horatio-sans-serif
pushed a commit
to horatio-sans-serif/bottle
that referenced
this pull request
Jul 28, 2025
"SameSite" cookie feature (from issue bottlepy#982)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #982,
set_cookie()does not support the "SameSite" cookie attribute.This is because the
http.cookiesmodule doesn't support that either.A reason for this isn't really given. It's just that the module was based on RFC 2109 which "SameSite" is not a part of.
In the python repository changes have been made and a pull request opened (python/cpython#214) so that
http.cookiescould eventually support "SameSite" natively in 3.7.However, since this is future stuff it doesn't really make a difference for bottle at the moment and i've come to the conclusion that it would be feature that's nice to have.
So i've added this feature to bottle, and updated the docs.
It doesn't to much, i just import the
_reserveddict in which valid attributes for cookies are stored,set_cookie()now supports the keywordsame_siteandraises aCookieErrorif the value forsame_siteisn'tstrictorlax`.This mimics petty much what the requested change for
http.cookiesin 3.7 would do.