Change Binary Download Distribution #54
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates the binary download distribution by adding fallback mechanisms and supporting a user agent parameter for enhanced control during downloads. Key changes include:
- Adding new properties (userAgent, isFallbackEnabled, downloadFailureException) and refactoring the Local.start method to handle fallback downloads in Local.cs.
- Modifying BrowserStackTunnel.addBinaryPath to accept additional parameters and adjusting downloadBinary to use a dynamic sourceUrl in BrowserStackTunnel.cs.
- Updating unit tests to match the new method signatures in both LocalTests.cs and BrowserStackTunnelTests.cs.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| BrowserStackLocal/BrowserStackLocal/Local.cs | Refactored start method and added fallback binary download logic |
| BrowserStackLocal/BrowserStackLocal/BrowserStackTunnel.cs | Updated addBinaryPath method signature and refactored download binary logic |
| BrowserStackLocal/BrowserStackLocal Unit Tests/LocalTests.cs | Adjusted mocks to accommodate new addBinaryPath parameters |
| BrowserStackLocal/BrowserStackLocal Unit Tests/BrowserStackTunnelTests.cs | Updated tests to reflect changes in method parameters |
kamal-kaur04
previously approved these changes
Jun 17, 2025
rounak610
approved these changes
Jun 18, 2025
rounak610
approved these changes
Jun 18, 2025
kamal-kaur04
approved these changes
Jun 18, 2025
Merged
yashdsaraf
approved these changes
Jun 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.