option to skip CYCLE sequences in action sequence #134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a new option "--skipcycled" which forces sequences with the CYCLE option to be reported at 0% usage, thus not creating WARNINGs and CRITICALs for these sequences. The default is still the old behaviour (no special treatment for CYCLE sequences).
|
Rationale: sequences are by default NO CYCLE, if a sequence is set to CYCLE it was done by the developer's/DBA's explicit statement. Let's assume they knew what they were doing and give them an option to not have false alarms when a sequence approaches it's cycling point. The default NO CYCLE sequences are still warned about. Also, the default behaviour of this check hasn't changed (no surprises). Added docs to "--man" and amended the tests (passing on 9.6 and 10). |
|
I agree with the logic and approach; looks good here; there was a minor comment spelling introduced which I will fixup after. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new option "--skipcycled" which forces sequences
with the CYCLE option to be reported at 0% usage, thus not creating
WARNINGs and CRITICALs for these sequences. The default is still
the old behaviour (no special treatment for CYCLE sequences).