Fix broken insufficient privileges detection

This hasn't worked for quite some time because `pg_stat_activity` columns `state_change` and `backend_type` are `null` when the user isn't a superuser.
bucardo · jcoleman · Feb 2, 2022 · Feb 2, 2022 · Jan 26, 2022 · Feb 2, 2022
commit 6b029f73ae58e7e39b4d827be0517bc19e22459b
diff --git a/check_postgres.pl b/check_postgres.pl
@@ -6931,7 +6931,7 @@ sub check_query_time {
                    msg('queries'),
                    msg('query-time'),
                    'query_start',
-                   q{query_start IS NOT NULL AND current_query NOT LIKE '<IDLE>%'});
+                   q{current_query NOT LIKE '<IDLE>%'});
 
     return;
 
@@ -8703,7 +8703,7 @@ sub check_txn_idle {
     $SQL3 =~ s/query_start/state_change/g;
 
     ## For Pg 10 and above, consider only client backends
-    ($SQL4 = $SQL3) =~ s/ WHERE / WHERE backend_type = 'client backend' AND /;
+    ($SQL4 = $SQL3) =~ s/ WHERE / WHERE (backend_type = 'client backend' OR backend_type IS NULL) AND /;
 
     my $info = run_command($SQL, { emptyok => 1 , version => [ "<8.3 $SQL2", ">9.6 $SQL4", ">9.1 $SQL3" ] } );
 

diff --git a/t/02_query_time.t b/t/02_query_time.t
@@ -6,7 +6,7 @@ use 5.008;
 use strict;
 use warnings;
 use Data::Dumper;
-use Test::More tests => 13;
+use Test::More tests => 14;
 use lib 't','.';
 use CP_Testing;
 
@@ -75,4 +75,31 @@ like ($cp->run(q{-w 1 -vv}), qr{$label WARNING:}, $t);
 $dbh->rollback();
 $dbh->disconnect();
 
+waitpid $child, 0;
+
+## Tests for non-superuser
+
+my $cp_nosuper = CP_Testing->new( {default_action => 'query_time', testuser => 'non_superuser', testuser_is_nosuper => 1 } );
+
+# Test that a non-superuser shows the unknown data alert.
+$child = fork();
+if (0 == $child) {
+    my $kiddbh = $cp->test_database_handle();
+    $cp->database_sleep($kiddbh, 3);
+    $kiddbh->rollback();
+    $kiddbh->disconnect();
+    exit;
+}
+
+my $dbh_nosuper = $cp_nosuper->test_database_handle();
+sleep 1;
+$t = qq{$S detects non-superuser access};
+like ($cp_nosuper->run(q{-w 1 -vv}), qr{$label UNKNOWN.+superuser}, $t);
+$dbh_nosuper->rollback();
+$dbh_nosuper->disconnect();
+
+$dbh->disconnect();
+
+waitpid $child, 0;
+
 exit;