Update pyproject.toml #21
Conversation
There was a problem hiding this comment.
Summary of Changes
Hello @haochengxia, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request updates the pyproject.toml file to modify the MACOSX_DEPLOYMENT_TARGET environment variable. This change likely aims to adjust the minimum macOS version targeted during the build process, potentially for broader compatibility or to align with specific build requirements.
Highlights
- Build Configuration: The MACOSX_DEPLOYMENT_TARGET environment variable in pyproject.toml has been updated from 15.0 to 14.0. This change affects the minimum macOS version that built artifacts will target.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request updates the MACOSX_DEPLOYMENT_TARGET for cibuildwheel from 15.0 to 14.0. This is a positive change as it aligns the target with a stable macOS release and ensures consistency with the CMAKE_OSX_DEPLOYMENT_TARGET already defined in the [tool.scikit-build] section. My review includes a suggestion to address configuration duplication for better long-term maintainability.
| @@ -80,7 +80,7 @@ build = ["cp39-*", "cp310-*", "cp311-*", "cp312-*", "cp313-*"] | |||
| skip = ["*-win32", "*-manylinux_i686", "*-musllinux*", "pp*"] | |||
|
|
|||
| # Set the environment variable for the wheel build step. | |||
| environment = { LCS_BUILD_DIR = "{project}/src/libCacheSim/build", MACOSX_DEPLOYMENT_TARGET = "15.0" } | |||
| environment = { LCS_BUILD_DIR = "{project}/src/libCacheSim/build", MACOSX_DEPLOYMENT_TARGET = "14.0" } | |||
There was a problem hiding this comment.
This change correctly aligns the two macOS deployment target settings, which is a good improvement. To further improve maintainability, you could consider removing the CMAKE_OSX_DEPLOYMENT_TARGET definition from [tool.scikit-build] (line 52) and rely on this environment variable as the single source of truth, as scikit-build-core will automatically use it. This would prevent the two values from becoming out of sync in the future.
A potential trade-off is that local builds (not using cibuildwheel) would then depend on the developer's environment or the Python interpreter's default deployment target, rather than being explicitly pinned in pyproject.toml.
No description provided.