Clean up CMakeLists #23
Conversation
There was a problem hiding this comment.
Summary of Changes
Hello @haochengxia, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
I've streamlined the CMakeLists.txt file by removing redundant and overly explicit path configurations. The primary goal was to simplify dependency resolution for ZSTD, XGBoost, and LightGBM, moving towards a more standard and less verbose CMake approach. This cleanup also involved removing the optional TCMalloc dependency, making the build configuration leaner and more maintainable.
Highlights
- Path Configuration Simplification: Removed hardcoded USER_PREFIX and related CMAKE_PREFIX_PATH, CMAKE_LIBRARY_PATH, and CMAKE_INCLUDE_PATH modifications, relying on CMake's default search mechanisms.
- Streamlined Dependency Finding: Simplified the find_package calls for ZSTD, XGBoost, and LightGBM, removing complex manual search logic and explicit path hints, and enforcing REQUIRED for ZSTD and XGBoost.
- TCMalloc Dependency Removal: Eliminated the optional TCMalloc dependency, reducing complexity in the build configuration.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request does a great job of cleaning up the CMakeLists.txt file by removing hardcoded paths and simplifying dependency finding. My review includes suggestions to further modernize the CMake script by removing redundant checks and outdated commands, and using find_package more consistently. I've also flagged the removal of TCMalloc support, as it might be an unintentional change that affects functionality.
No description provided.