Add PHPStan to test environment #200
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimonFrings
approved these changes
Oct 24, 2022
This was referenced Oct 24, 2022
This was referenced Nov 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changeset adds PHPStan to the test environment for all supported PHP versions. This intentionally starts small with level 5 only to avoid most common issues that can be detected with static analysis.
Adding PHPStan for newer PHP versions is relative straight forward, most of the work in this PR went into making sure this works across the entire test matrix. I consider this to be a decent starting point to increase the level and/or introduce a baseline in a follow-up PR in the future.
Refs #199 and phpstan/phpstan#4060