Upgrade checkstyle to 8.25 and fix upgrade script #22
Conversation
|
Hi @butterflysky - thanks for the PR 👌 Putting this in the queue for review. |
|
Hi @butterflysky - quick update: we'll need to first upgrade this repo to use Circle 2 before merging this.
|
|
May I ask if there is an ETA for the circle 2 update? |
|
Hi Jannis, Checking with the team and will let you know. |
|
Hey, thanks for your support. Is there an update already? |
|
Hi @efueger; thanks for your help so far! Just checking in to see if this is still blocked. Please let me know if there's anything I can do to help. |
|
Hi @butterflysky - thanks so much for your patience and the nudge! We have work scheduled in an upcoming sprint for these updates. I'll be in touch as soon as I see any updates. 👌 |
|
Thank you @efueger , have a great day, and I'll continue to be patient. :) |
|
Hi @butterflysky - Good news! We've updated our Circle setup and are now using Checkstyle 8.26 Thanks again for the nudge 👌 |
|
Thanks y'all! Have a great week! |
One of the projects I manage with CodeClimate uses a checkstyle configuration that's incompatible with versions <8.24. I just tried to enable CodeClimate's Checkstyle plugin and found it didn't work with my configuration, so I went to upgrade the support.
This diff fixes the upgrade script to find the latest version of checkstyle's jar file (moved from sourceforge to github). It also applies the upgrade and fixes up a few things in the default configuration that are no longer compatible with versions of Checkstyle >=8.24. Now all the tests pass cleanly.