Python: don't crash on complex-number literals #364
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also: if this is added, it may cause projects to see a spike in detection numbers. Our package QuTiP would jump from 102 duplication issues to 190, for example. |
f-moya
approved these changes
Jul 30, 2021
803fd80 to
5dd5eed
Compare
Complex literals cannot be serialised directly to JSON, but Python's AST reports them as constant numeric values. Ruby's `to_json` method serialies complex numbers to their string representations, so we do similar here. An alternative would be to serialise to a two-element list of the real and imaginary parts.
5dd5eed to
5b01aa3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #363: crashing on complex-number literals in Python 2 and 3. I modified the JSON serialiser to string-ify complex numbers, rather than passing them directly as numeric values. That's perhaps not 100% ideal, but it's the same as the behaviour of Ruby's
to_jsonmethod. I've added a test that the behaviour works, as well.Running
codeclimate analyzeon the same test file in issue #363 with the same settings (mass_threshold: 1) now produces the expected output in both Python 2 and Python 3: