Ignore unparsable stdout #40
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looking at the full stack from this bugsnag[1]
Originating from:
This tells me an engine output { begin: null }. The events for this
errored build show it was a fixme engine that did this.
It looks like grep outputting to stdout something that doesn't match the
expected format could easily cause this:
An assertion that we have all the values we expected before printing the
issue should prevent downstream errors.
NOTE: CLI validations would catch this, since they run before the output
filter. In builder's case, the output filter runs before validations so
invalid issues can get in there and cause these errors. Addressing this
is a larger track of work, so fixing misbehaving engines is valuable in
the meantime.
1: https://bugsnag.com/code-climate/builder/errors/57546cf2be3f29e6a63111c8?event_id=5769f0b4076813321236b4e1
/cc @codeclimate/review @mrb