Skip to content

Feat(jssg): better validation #1620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

Feat(jssg): better validation #1620

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
ce9b82f
WIP
AugustinMauroy Jul 18, 2025
64caa70
WIP
AugustinMauroy Jul 18, 2025
92a02bc
include bundler
AugustinMauroy Jul 18, 2025
8734d82
fix ?
AugustinMauroy Jul 18, 2025
0dfc51d
WIP
AugustinMauroy Jul 22, 2025
a5a6521
Update publish.rs
AugustinMauroy Jul 22, 2025
75a2b83
Update validate.rs
AugustinMauroy Jul 22, 2025
e46ddb0
Update workflow.rs
AugustinMauroy Jul 22, 2025
4bb8cbb
Merge remote-tracking branch 'upstream/main' into feat-bundle
AugustinMauroy Jul 22, 2025
54e65b7
fix: fmt
AugustinMauroy Jul 22, 2025
ad5d53a
fix
AugustinMauroy Jul 22, 2025
10d78fd
Update utils.rs
AugustinMauroy Jul 22, 2025
e6c403a
fix: fmt
AugustinMauroy Jul 22, 2025
93323e6
add dep
AugustinMauroy Jul 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: fmt
  • Loading branch information
@AugustinMauroy
AugustinMauroy committed Jul 22, 2025
commit e6c403abe08f65ab864e0ecf7e10dbc6932955d2
8 changes: 4 additions & 4 deletions crates/core/src/utils.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
use std::collections::{HashMap, HashSet};
use std::fs;
use std::path::{Path, PathBuf};
use serde_yaml;
use anyhow::{Context, Result};
use butterflow_models::step::StepAction;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We use anyhow in CLI only. In CLI, we use anyhow for ergonomic error propagation and user-facing reports.
In core/library crates, we define typed errors with thiserror.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

got it I had moved the function from cli to core to reused it so I have to modify that

use butterflow_models::{Error, Node, Result, Workflow};
use serde_yaml;
use std::collections::{HashMap, HashSet};
use std::fs;
use std::path::{Path, PathBuf};

/// Parse a workflow definition from a file
pub fn parse_workflow_file<P: AsRef<Path>>(path: P) -> Result<Workflow> {
Expand Down
Loading
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy