fix: Use immutable names for volumes in example templates

mafredri · mafredri · commit 193e2b407e54 · 2022-11-08T15:14:48.000Z
This contributes towards #3000, #3386 Related #3409
diff --git a/docs/templates.md b/docs/templates.md
@@ -184,7 +184,7 @@ data "coder_workspace" "me" {
 resource "docker_volume" "home_volume" {
   # persistent resource (remains a workspace is stopped)
   count = 1
-  name  = "coder-${data.coder_workspace.me.owner}-${data.coder_workspace.me.name}-root"
+  name  = "coder-${data.coder_workspace.me.owner_id}-${data.coder_workspace.me.id}-home"
 }
 
 resource "docker_container" "workspace" {
diff --git a/dogfood/main.tf b/dogfood/main.tf
@@ -54,7 +54,7 @@ resource "coder_app" "code-server" {
 }
 
 resource "docker_volume" "home_volume" {
-  name = "coder-${data.coder_workspace.me.owner}-${data.coder_workspace.me.name}-home"
+  name = "coder-${data.coder_workspace.me.owner_id}-${data.coder_workspace.me.id}-home"
   lifecycle {
     ignore_changes = all
   }
diff --git a/examples/templates/do-linux/main.tf b/examples/templates/do-linux/main.tf
@@ -100,7 +100,7 @@ resource "coder_agent" "main" {
 
 resource "digitalocean_volume" "home_volume" {
   region                   = var.region
-  name                     = "coder-${data.coder_workspace.me.owner}-${data.coder_workspace.me.name}-home"
+  name                     = "coder-${data.coder_workspace.me.owner_id}-${data.coder_workspace.me.id}-home"
   size                     = var.home_volume_size
   initial_filesystem_type  = "ext4"
   initial_filesystem_label = "coder-home"
diff --git a/examples/templates/docker-code-server/main.tf b/examples/templates/docker-code-server/main.tf
@@ -54,7 +54,7 @@ resource "coder_app" "code-server" {
 }
 
 resource "docker_volume" "home_volume" {
-  name = "coder-${data.coder_workspace.me.owner}-${data.coder_workspace.me.name}-root"
+  name = "coder-${data.coder_workspace.me.owner_id}-${data.coder_workspace.me.id}-home"
 }
 
 resource "docker_container" "workspace" {
diff --git a/examples/templates/docker-image-builds/main.tf b/examples/templates/docker-image-builds/main.tf
@@ -69,7 +69,7 @@ variable "docker_image" {
 }
 
 resource "docker_volume" "home_volume" {
-  name = "coder-${data.coder_workspace.me.owner}-${lower(data.coder_workspace.me.name)}-root"
+  name = "coder-${data.coder_workspace.me.owner_id}-${data.coder_workspace.me.id}-home"
 }
 
 resource "docker_image" "coder_image" {
diff --git a/examples/templates/docker-with-dotfiles/main.tf b/examples/templates/docker-with-dotfiles/main.tf
@@ -47,7 +47,7 @@ resource "coder_agent" "main" {
 }
 
 resource "docker_volume" "home_volume" {
-  name = "coder-${data.coder_workspace.me.owner}-${lower(data.coder_workspace.me.name)}-root"
+  name = "coder-${data.coder_workspace.me.owner_id}-${data.coder_workspace.me.id}-home"
 }
 
 resource "docker_container" "workspace" {
diff --git a/examples/templates/docker/main.tf b/examples/templates/docker/main.tf
@@ -60,7 +60,7 @@ resource "coder_app" "code-server" {
 
 
 resource "docker_volume" "home_volume" {
-  name = "coder-${data.coder_workspace.me.owner}-${lower(data.coder_workspace.me.name)}-home"
+  name = "coder-${data.coder_workspace.me.owner_id}-${data.coder_workspace.me.id}-home"
 }
 
 
diff --git a/examples/templates/gcp-linux/main.tf b/examples/templates/gcp-linux/main.tf
@@ -36,7 +36,7 @@ data "coder_workspace" "me" {
 }
 
 resource "google_compute_disk" "root" {
-  name  = "coder-${lower(data.coder_workspace.me.owner)}-${lower(data.coder_workspace.me.name)}-root"
+  name  = "coder-${data.coder_workspace.me.owner_id}-${data.coder_workspace.me.id}-root"
   type  = "pd-ssd"
   zone  = var.zone
   image = "debian-cloud/debian-11"
diff --git a/examples/templates/gcp-windows/main.tf b/examples/templates/gcp-windows/main.tf
@@ -36,7 +36,7 @@ data "google_compute_default_service_account" "default" {
 }
 
 resource "google_compute_disk" "root" {
-  name  = "coder-${lower(data.coder_workspace.me.owner)}-${lower(data.coder_workspace.me.name)}-root"
+  name  = "coder-${data.coder_workspace.me.owner_id}-${data.coder_workspace.me.id}-root"
   type  = "pd-ssd"
   zone  = var.zone
   image = "projects/windows-cloud/global/images/windows-server-2022-dc-core-v20220215"

Original file line number	Diff line number	Diff line change
`@@ -184,7 +184,7 @@ data "coder_workspace" "me" {`
`184`	`184`	`resource "docker_volume" "home_volume" {`
`185`	`185`	`# persistent resource (remains a workspace is stopped)`
`186`	`186`	`count = 1`
`187`		`- name = "coder-${data.coder_workspace.me.owner}-${data.coder_workspace.me.name}-root"`
	`187`	`+ name = "coder-${data.coder_workspace.me.owner_id}-${data.coder_workspace.me.id}-home"`
`188`	`188`	`}`
`189`	`189`
`190`	`190`	`resource "docker_container" "workspace" {`
Original file line number	Diff line number	Diff line change
`@@ -54,7 +54,7 @@ resource "coder_app" "code-server" {`
`54`	`54`	`}`
`55`	`55`
`56`	`56`	`resource "docker_volume" "home_volume" {`
`57`		`- name = "coder-${data.coder_workspace.me.owner}-${data.coder_workspace.me.name}-home"`
	`57`	`+ name = "coder-${data.coder_workspace.me.owner_id}-${data.coder_workspace.me.id}-home"`
`58`	`58`	`lifecycle {`
`59`	`59`	`ignore_changes = all`
`60`	`60`	`}`
Original file line number	Diff line number	Diff line change
`@@ -69,7 +69,7 @@ variable "docker_image" {`
`69`	`69`	`}`
`70`	`70`
`71`	`71`	`resource "docker_volume" "home_volume" {`
`72`		`- name = "coder-${data.coder_workspace.me.owner}-${lower(data.coder_workspace.me.name)}-root"`
	`72`	`+ name = "coder-${data.coder_workspace.me.owner_id}-${data.coder_workspace.me.id}-home"`
`73`	`73`	`}`
`74`	`74`
`75`	`75`	`resource "docker_image" "coder_image" {`
Original file line number	Diff line number	Diff line change
`@@ -47,7 +47,7 @@ resource "coder_agent" "main" {`
`47`	`47`	`}`
`48`	`48`
`49`	`49`	`resource "docker_volume" "home_volume" {`
`50`		`- name = "coder-${data.coder_workspace.me.owner}-${lower(data.coder_workspace.me.name)}-root"`
	`50`	`+ name = "coder-${data.coder_workspace.me.owner_id}-${data.coder_workspace.me.id}-home"`
`51`	`51`	`}`
`52`	`52`
`53`	`53`	`resource "docker_container" "workspace" {`
Original file line number	Diff line number	Diff line change
`@@ -60,7 +60,7 @@ resource "coder_app" "code-server" {`
`60`	`60`
`61`	`61`
`62`	`62`	`resource "docker_volume" "home_volume" {`
`63`		`- name = "coder-${data.coder_workspace.me.owner}-${lower(data.coder_workspace.me.name)}-home"`
	`63`	`+ name = "coder-${data.coder_workspace.me.owner_id}-${data.coder_workspace.me.id}-home"`
`64`	`64`	`}`
`65`	`65`
`66`	`66`
Original file line number	Diff line number	Diff line change
`@@ -36,7 +36,7 @@ data "coder_workspace" "me" {`
`36`	`36`	`}`
`37`	`37`
`38`	`38`	`resource "google_compute_disk" "root" {`
`39`		`- name = "coder-${lower(data.coder_workspace.me.owner)}-${lower(data.coder_workspace.me.name)}-root"`
	`39`	`+ name = "coder-${data.coder_workspace.me.owner_id}-${data.coder_workspace.me.id}-root"`
`40`	`40`	`type = "pd-ssd"`
`41`	`41`	`zone = var.zone`
`42`	`42`	`image = "debian-cloud/debian-11"`
Original file line number	Diff line number	Diff line change
`@@ -36,7 +36,7 @@ data "google_compute_default_service_account" "default" {`
`36`	`36`	`}`
`37`	`37`
`38`	`38`	`resource "google_compute_disk" "root" {`
`39`		`- name = "coder-${lower(data.coder_workspace.me.owner)}-${lower(data.coder_workspace.me.name)}-root"`
	`39`	`+ name = "coder-${data.coder_workspace.me.owner_id}-${data.coder_workspace.me.id}-root"`
`40`	`40`	`type = "pd-ssd"`
`41`	`41`	`zone = var.zone`
`42`	`42`	`image = "projects/windows-cloud/global/images/windows-server-2022-dc-core-v20220215"`