lint/fmt

dannykopping · dannykopping · commit 275bfcadd687 · 2024-08-15T11:39:17.000+02:00
Signed-off-by: Danny Kopping &lt;danny@coder.com&gt;
diff --git a/coderd/database/dbmem/dbmem.go b/coderd/database/dbmem/dbmem.go
@@ -3172,13 +3172,28 @@ func (q *FakeQuerier) GetProvisionerJobByID(ctx context.Context, id uuid.UUID) (
 	return q.getProvisionerJobByIDNoLock(ctx, id)
 }
 
-func (q *FakeQuerier) GetProvisionerJobStatsByWorkspace(ctx context.Context, arg database.GetProvisionerJobStatsByWorkspaceParams) (database.ProvisionerJobStat, error) {
+func (*FakeQuerier) GetProvisionerJobStatsByWorkspace(_ context.Context, arg database.GetProvisionerJobStatsByWorkspaceParams) (database.ProvisionerJobStat, error) {
 	err := validateDatabaseType(arg)
 	if err != nil {
 		return database.ProvisionerJobStat{}, err
 	}
 
-	panic("not implemented")
+	return database.ProvisionerJobStat{
+		JobID:          arg.JobID,
+		JobStatus:      database.ProvisionerJobStatusSucceeded,
+		WorkspaceID:    arg.WorkspaceID,
+		WorkerID:       uuid.NullUUID{UUID: uuid.New(), Valid: true},
+		Error:          sql.NullString{},
+		ErrorCode:      sql.NullString{},
+		UpdatedAt:      dbtime.Now(),
+		QueuedSecs:     0.1,
+		CompletionSecs: 10,
+		CanceledSecs:   0,
+		InitSecs:       1,
+		PlanSecs:       2,
+		GraphSecs:      3,
+		ApplySecs:      4,
+	}, nil
 }
 
 func (q *FakeQuerier) GetProvisionerJobsByIDs(_ context.Context, ids []uuid.UUID) ([]database.ProvisionerJob, error) {
@@ -6642,13 +6657,13 @@ func (q *FakeQuerier) InsertProvisionerJobLogs(_ context.Context, arg database.I
 	return logs, nil
 }
 
-func (q *FakeQuerier) InsertProvisionerJobTimings(ctx context.Context, arg database.InsertProvisionerJobTimingsParams) ([]database.ProvisionerJobTiming, error) {
+func (*FakeQuerier) InsertProvisionerJobTimings(_ context.Context, arg database.InsertProvisionerJobTimingsParams) ([]database.ProvisionerJobTiming, error) {
 	err := validateDatabaseType(arg)
 	if err != nil {
 		return nil, err
 	}
 
-	panic("not implemented")
+	return nil, nil
 }
 
 func (q *FakeQuerier) InsertProvisionerKey(_ context.Context, arg database.InsertProvisionerKeyParams) (database.ProvisionerKey, error) {
diff --git a/coderd/database/dbtime/dbtime.go b/coderd/database/dbtime/dbtime.go
@@ -11,4 +11,4 @@ func Now() time.Time {
 // microsecond precision.
 func Time(t time.Time) time.Time {
 	return t.UTC().Round(time.Microsecond)
-}
+}
diff --git a/coderd/provisionerdserver/provisionerdserver.go b/coderd/provisionerdserver/provisionerdserver.go
@@ -1442,6 +1442,7 @@ func (s *server) CompleteJob(ctx context.Context, completed *proto.CompletedJob)
 		}
 
 		// Insert timings outside transaction since it is metadata.
+		// nolint:exhaustruct // The other fields are set further down.
 		params := database.InsertProvisionerJobTimingsParams{
 			JobID: jobID,
 		}
diff --git a/coderd/workspacebuilds.go b/coderd/workspacebuilds.go
@@ -676,6 +676,7 @@ func (api *API) workspaceBuildStats(rw http.ResponseWriter, r *http.Request) {
 			Message: "Failed to get workspace build stats",
 			Detail:  err.Error(),
 		})
+		return
 	}
 
 	httpapi.Write(ctx, rw, http.StatusOK, convertWorkspaceBuildStats(pj))
diff --git a/provisioner/terraform/executor.go b/provisioner/terraform/executor.go
@@ -15,12 +15,13 @@ import (
 	"sync"
 	"time"
 
-	"cdr.dev/slog"
 	"github.com/hashicorp/go-version"
 	tfjson "github.com/hashicorp/terraform-json"
 	"go.opentelemetry.io/otel/attribute"
 	"golang.org/x/xerrors"
 
+	"cdr.dev/slog"
+
 	"github.com/coder/coder/v2/coderd/database"
 	"github.com/coder/coder/v2/coderd/tracing"
 	"github.com/coder/coder/v2/provisionersdk/proto"
diff --git a/provisioner/terraform/timings_internal_test.go b/provisioner/terraform/timings_internal_test.go
@@ -54,6 +54,7 @@ func TestAggregation(t *testing.T) {
 		},
 	}
 
+	// nolint:paralleltest // Not since go v1.22.
 	for _, tc := range tests {
 		t.Run(tc.name, func(t *testing.T) {
 			t.Parallel()
diff --git a/provisionerd/runner/runner.go b/provisionerd/runner/runner.go
@@ -1012,7 +1012,7 @@ func (r *Runner) runWorkspaceBuild(ctx context.Context) (*proto.CompletedJob, *p
 			Error: applyComplete.Error,
 			Type: &proto.FailedJob_WorkspaceBuild_{
 				WorkspaceBuild: &proto.FailedJob_WorkspaceBuild{
-					State: applyComplete.State,
+					State:   applyComplete.State,
 					Timings: applyComplete.Timings,
 				},
 			},
@@ -1032,7 +1032,7 @@ func (r *Runner) runWorkspaceBuild(ctx context.Context) (*proto.CompletedJob, *p
 			WorkspaceBuild: &proto.CompletedJob_WorkspaceBuild{
 				State:     applyComplete.State,
 				Resources: applyComplete.Resources,
-				Timings: applyComplete.Timings,
+				Timings:   applyComplete.Timings,
 			},
 		},
 	}, nil

Original file line number	Diff line number	Diff line change
`@@ -1442,6 +1442,7 @@ func (s server) CompleteJob(ctx context.Context, completed proto.CompletedJob)`
`1442`	`1442`	`}`
`1443`	`1443`
`1444`	`1444`	`// Insert timings outside transaction since it is metadata.`
	`1445`	`+ // nolint:exhaustruct // The other fields are set further down.`
`1445`	`1446`	`params := database.InsertProvisionerJobTimingsParams{`
`1446`	`1447`	`JobID: jobID,`
`1447`	`1448`	`}`
Original file line number	Diff line number	Diff line change
`@@ -676,6 +676,7 @@ func (api API) workspaceBuildStats(rw http.ResponseWriter, r http.Request) {`
`676`	`676`	`Message: "Failed to get workspace build stats",`
`677`	`677`	`Detail: err.Error(),`
`678`	`678`	`})`
	`679`	`+ return`
`679`	`680`	`}`
`680`	`681`
`681`	`682`	`httpapi.Write(ctx, rw, http.StatusOK, convertWorkspaceBuildStats(pj))`
Original file line number	Diff line number	Diff line change
`@@ -54,6 +54,7 @@ func TestAggregation(t *testing.T) {`
`54`	`54`	`},`
`55`	`55`	`}`
`56`	`56`
	`57`	`+ // nolint:paralleltest // Not since go v1.22.`
`57`	`58`	`for _, tc := range tests {`
`58`	`59`	`t.Run(tc.name, func(t *testing.T) {`
`59`	`60`	`t.Parallel()`