fix: loosen timing checks for heartbeats (#15923)

spikecurtis · web-flow · commit 63572d9f5370 · 2024-12-19T13:49:01.000+04:00
Fixes #15782. I believe that Windows doesn't always have high-resolution timers available, so this PR loosens the check for PG Coordinator heartbeats, to avoid flakes like: https://github.com/coder/coder/actions/runs/12397381823/job/34607639048
diff --git a/enterprise/tailnet/pgcoord_test.go b/enterprise/tailnet/pgcoord_test.go
@@ -410,7 +410,7 @@ func TestPGCoordinatorSingle_SendsHeartbeats(t *testing.T) {
 		}
 		require.Greater(t, heartbeats[0].Sub(start), time.Duration(0))
 		require.Greater(t, heartbeats[1].Sub(start), time.Duration(0))
-		return assert.Greater(t, heartbeats[1].Sub(heartbeats[0]), tailnet.HeartbeatPeriod*9/10)
+		return assert.Greater(t, heartbeats[1].Sub(heartbeats[0]), tailnet.HeartbeatPeriod*3/4)
 	}, testutil.WaitMedium, testutil.IntervalMedium)
 }
 

Original file line number	Diff line number	Diff line change
`@@ -410,7 +410,7 @@ func TestPGCoordinatorSingle_SendsHeartbeats(t *testing.T) {`
`410`	`410`	`}`
`411`	`411`	`require.Greater(t, heartbeats[0].Sub(start), time.Duration(0))`
`412`	`412`	`require.Greater(t, heartbeats[1].Sub(start), time.Duration(0))`
`413`		`- return assert.Greater(t, heartbeats[1].Sub(heartbeats[0]), tailnet.HeartbeatPeriod*9/10)`
	`413`	`+ return assert.Greater(t, heartbeats[1].Sub(heartbeats[0]), tailnet.HeartbeatPeriod*3/4)`
`414`	`414`	`}, testutil.WaitMedium, testutil.IntervalMedium)`
`415`	`415`	`}`
`416`	`416`