fix(coderd/database): linter

evgeniy-scherbina · evgeniy-scherbina · commit 8b3446eee437 · 2025-02-27T11:35:46.000-05:00
diff --git a/coderd/database/querier_test.go b/coderd/database/querier_test.go
@@ -2166,10 +2166,10 @@ func TestExpectOne(t *testing.T) {
 }
 
 func TestGetProvisionerJobsByIDsWithQueuePosition(t *testing.T) {
+	t.Parallel()
 	if !dbtestutil.WillUsePostgres() {
 		t.SkipNow()
 	}
-	t.Parallel()
 
 	now := dbtime.Now()
 	ctx := testutil.Context(t, testutil.WaitShort)
@@ -2470,10 +2470,10 @@ func TestGetProvisionerJobsByIDsWithQueuePosition(t *testing.T) {
 }
 
 func TestGetProvisionerJobsByIDsWithQueuePosition_MixedStatuses(t *testing.T) {
+	t.Parallel()
 	if !dbtestutil.WillUsePostgres() {
 		t.SkipNow()
 	}
-	t.Parallel()
 
 	db, _ := dbtestutil.NewDB(t)
 	now := dbtime.Now()
@@ -2611,10 +2611,10 @@ func TestGetProvisionerJobsByIDsWithQueuePosition_MixedStatuses(t *testing.T) {
 }
 
 func TestGetProvisionerJobsByIDsWithQueuePosition_OrderValidation(t *testing.T) {
+	t.Parallel()
 	if !dbtestutil.WillUsePostgres() {
 		t.SkipNow()
 	}
-	t.Parallel()
 
 	db, _ := dbtestutil.NewDB(t)
 	now := dbtime.Now()
diff --git a/coderd/database/queries.sql.go b/coderd/database/queries.sql.go
diff --git a/coderd/database/queries/provisionerjobs.sql b/coderd/database/queries/provisionerjobs.sql
@@ -57,7 +57,7 @@ WITH filtered_provisioner_jobs AS (
 	FROM
 		provisioner_jobs
 	WHERE
-		id = ANY(@ids :: uuid [ ]) -- Apply filter early to reduce dataset size before expensive JOINs
+		id = ANY(@ids :: uuid [ ]) -- Apply filter early to reduce dataset size before expensive JOIN
 ),
 pending_jobs AS (
 	-- Step 2: Extract only pending jobs
@@ -90,7 +90,7 @@ final_jobs AS (
 	FROM
 		filtered_provisioner_jobs fpj -- Use the pre-filtered dataset instead of full provisioner_jobs
 			LEFT JOIN ranked_jobs rj
-					ON fpj.id = rj.id -- Ensure we only keep jobs that have a ranking
+					ON fpj.id = rj.id -- Join with the ranking jobs CTE to assign a rank to each specified provisioner job.
 	GROUP BY
 		fpj.id, fpj.created_at
 )

Original file line number	Diff line number	Diff line change
`@@ -2166,10 +2166,10 @@ func TestExpectOne(t *testing.T) {`
`2166`	`2166`	`}`
`2167`	`2167`
`2168`	`2168`	`func TestGetProvisionerJobsByIDsWithQueuePosition(t *testing.T) {`
	`2169`	`+ t.Parallel()`
`2169`	`2170`	`if !dbtestutil.WillUsePostgres() {`
`2170`	`2171`	`t.SkipNow()`
`2171`	`2172`	`}`
`2172`		`- t.Parallel()`
`2173`	`2173`
`2174`	`2174`	`now := dbtime.Now()`
`2175`	`2175`	`ctx := testutil.Context(t, testutil.WaitShort)`
`@@ -2470,10 +2470,10 @@ func TestGetProvisionerJobsByIDsWithQueuePosition(t *testing.T) {`
`2470`	`2470`	`}`
`2471`	`2471`
`2472`	`2472`	`func TestGetProvisionerJobsByIDsWithQueuePosition_MixedStatuses(t *testing.T) {`
	`2473`	`+ t.Parallel()`
`2473`	`2474`	`if !dbtestutil.WillUsePostgres() {`
`2474`	`2475`	`t.SkipNow()`
`2475`	`2476`	`}`
`2476`		`- t.Parallel()`
`2477`	`2477`
`2478`	`2478`	`db, _ := dbtestutil.NewDB(t)`
`2479`	`2479`	`now := dbtime.Now()`
`@@ -2611,10 +2611,10 @@ func TestGetProvisionerJobsByIDsWithQueuePosition_MixedStatuses(t *testing.T) {`
`2611`	`2611`	`}`
`2612`	`2612`
`2613`	`2613`	`func TestGetProvisionerJobsByIDsWithQueuePosition_OrderValidation(t *testing.T) {`
	`2614`	`+ t.Parallel()`
`2614`	`2615`	`if !dbtestutil.WillUsePostgres() {`
`2615`	`2616`	`t.SkipNow()`
`2616`	`2617`	`}`
`2617`		`- t.Parallel()`
`2618`	`2618`
`2619`	`2619`	`db, _ := dbtestutil.NewDB(t)`
`2620`	`2620`	`now := dbtime.Now()`